-
Notifications
You must be signed in to change notification settings - Fork 471
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8297316: [TestBug] LocalDateTimeStringConverterTest.testChronologyConsistency fails with JDK 20 #1114
Conversation
👋 Welcome back arapte! A progress list of the required criteria for merging this PR into |
Webrevs
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The fix looks good. I left a (minor) comment suggesting that the initialization of the static JAPANESE_DATE_STRING
field only needs to be done once for the class and not for each instance. I'll reapprove if you want to change it.
final var version = Runtime.Version.parse(System.getProperty("java.version")); | ||
if (version.major() < 20) { | ||
// TODO: This can be removed when the minimum version of boot jdk | ||
// for JFX build is updated to JDK20 or above. | ||
JAPANESE_DATE_STRING = "Saturday, January 12, 60 Shōwa, 12:34:56 PM"; | ||
} else { | ||
JAPANESE_DATE_STRING = "Saturday, January 12, 60 Shōwa, 12:34:56\u202fPM"; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor: I think this could move to the (static) @BeforeClass
method rather than being recomputed for each instance.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is now moved to the @BeforeClass
method.
@arapte This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 2 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
/integrate |
The expected result was changed due to an enhancement in JDK:
JDK-8284840: Update CLDR to Version 42.0
Similar tests were corrected in JDK along with the enhancement: check this for example
We need to make similar change. But the expected result is different before JDK20 and with JDK20. The fix checks JDK major version to change expected result accordingly.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx.git pull/1114/head:pull/1114
$ git checkout pull/1114
Update a local copy of the PR:
$ git checkout pull/1114
$ git pull https://git.openjdk.org/jfx.git pull/1114/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 1114
View PR using the GUI difftool:
$ git pr show -t 1114
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jfx/pull/1114.diff
Webrev
Link to Webrev Comment