Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8306329 : Update ICU4C to 73.1 #1138

Closed
wants to merge 14 commits into from

Conversation

HimaBinduMeda
Copy link
Contributor

@HimaBinduMeda HimaBinduMeda commented May 15, 2023

Updated ICU to v73.1. Verified build and sanity. No issues seen.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed (2 reviews required, with at least 1 Reviewer, 1 Author)

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx.git pull/1138/head:pull/1138
$ git checkout pull/1138

Update a local copy of the PR:
$ git checkout pull/1138
$ git pull https://git.openjdk.org/jfx.git pull/1138/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1138

View PR using the GUI difftool:
$ git pr show -t 1138

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jfx/pull/1138.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented May 15, 2023

👋 Welcome back hmeda! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@HimaBinduMeda HimaBinduMeda changed the title Draft: 8306329 : Update ICU4C to 73 8306329 : Update ICU4C to 73 May 16, 2023
@openjdk openjdk bot added the rfr Ready for review label May 16, 2023
@mlbridge
Copy link

mlbridge bot commented May 16, 2023

Webrevs

@kevinrushforth
Copy link
Member

/reviewers 2

@openjdk
Copy link

openjdk bot commented May 16, 2023

@kevinrushforth
The total number of required reviews for this PR (including the jcheck configuration and the last /reviewers command) is now set to 2 (with at least 1 Reviewer, 1 Author).

@HimaBinduMeda HimaBinduMeda changed the title 8306329 : Update ICU4C to 73 8306329 : Update ICU4C to 73.1 May 17, 2023
Copy link
Member

@kevinrushforth kevinrushforth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good with one comment about a missing LICENSE section.

@kevinrushforth
Copy link
Member

@johanvos @tiainen Can one of you be the second reviewer?

Copy link
Collaborator

@johanvos johanvos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Buld + tests ok

@openjdk
Copy link

openjdk bot commented May 24, 2023

@HimaBinduMeda This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8306329: Update ICU4C to 73.1

Reviewed-by: kcr, jvos

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 5 new commits pushed to the master branch:

  • 8110f54: 8306328: Update libFFI to 3.4.4
  • bdadcb2: 8284542: [Accessibility] [Win] Missing attribute for toggle state of CheckBox in CheckBoxTreeItem
  • 6aeaff3: 8295078: TextField blurry when inside an TitledPane -> AnchorPane
  • bff41c2: 8308114: Bump minimum version of macOS for x64 to 11.0 (matching aarch64)
  • c1a1179: 8245919: Region#padding property rendering error

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Ready to be integrated label May 24, 2023
@HimaBinduMeda
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented May 24, 2023

Going to push as commit 2f5dcfd.
Since your change was applied there have been 5 commits pushed to the master branch:

  • 8110f54: 8306328: Update libFFI to 3.4.4
  • bdadcb2: 8284542: [Accessibility] [Win] Missing attribute for toggle state of CheckBox in CheckBoxTreeItem
  • 6aeaff3: 8295078: TextField blurry when inside an TitledPane -> AnchorPane
  • bff41c2: 8308114: Bump minimum version of macOS for x64 to 11.0 (matching aarch64)
  • c1a1179: 8245919: Region#padding property rendering error

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 24, 2023
@openjdk openjdk bot closed this May 24, 2023
@openjdk openjdk bot removed ready Ready to be integrated rfr Ready for review labels May 24, 2023
@openjdk
Copy link

openjdk bot commented May 24, 2023

@HimaBinduMeda Pushed as commit 2f5dcfd.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated
3 participants