Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8308114: Bump minimum version of macOS for x64 to 11.0 (matching aarch64) #1139

Closed

Conversation

kevinrushforth
Copy link
Member

@kevinrushforth kevinrushforth commented May 15, 2023

This PR bumps the minimum deployment target for JavaFX to macOS 11.0 (Big Sur) on x64 platforms, matching the current minimum on aarch64.

As a follow-on to this, I will file a (low-priority) cleanup issue to remove any @available checks for 10.x, since those will then be no-ops.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed (2 reviews required, with at least 1 Reviewer, 1 Author)

Issue

  • JDK-8308114: Bump minimum version of macOS for x64 to 11.0 (matching aarch64)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx.git pull/1139/head:pull/1139
$ git checkout pull/1139

Update a local copy of the PR:
$ git checkout pull/1139
$ git pull https://git.openjdk.org/jfx.git pull/1139/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1139

View PR using the GUI difftool:
$ git pr show -t 1139

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jfx/pull/1139.diff

Webrev

Link to Webrev Comment

@kevinrushforth
Copy link
Member Author

/reviewers 2

@bridgekeeper
Copy link

bridgekeeper bot commented May 15, 2023

👋 Welcome back kcr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Ready for review label May 15, 2023
@openjdk
Copy link

openjdk bot commented May 15, 2023

@kevinrushforth
The total number of required reviews for this PR (including the jcheck configuration and the last /reviewers command) is now set to 2 (with at least 1 Reviewer, 1 Author).

@mlbridge
Copy link

mlbridge bot commented May 15, 2023

Webrevs

@johanvos
Copy link
Collaborator

There were no objections raised on the mailinglist, hence I am ok with bumping to 11.0 for JavaFX 21.

@openjdk
Copy link

openjdk bot commented May 15, 2023

@kevinrushforth This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8308114: Bump minimum version of macOS for x64 to 11.0 (matching aarch64)

Reviewed-by: angorya, jvos

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Ready to be integrated label May 15, 2023
@kevinrushforth
Copy link
Member Author

I'll wait 24 hours to integrate this in case other concerns are raised.

@kevinrushforth
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented May 16, 2023

Going to push as commit bff41c2.
Since your change was applied there has been 1 commit pushed to the master branch:

  • c1a1179: 8245919: Region#padding property rendering error

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 16, 2023
@openjdk openjdk bot closed this May 16, 2023
@openjdk openjdk bot removed ready Ready to be integrated rfr Ready for review labels May 16, 2023
@openjdk
Copy link

openjdk bot commented May 16, 2023

@kevinrushforth Pushed as commit bff41c2.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@kevinrushforth kevinrushforth deleted the 8308114-macos-min-11.0 branch May 16, 2023 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated
3 participants