-
Notifications
You must be signed in to change notification settings - Fork 463
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8308114: Bump minimum version of macOS for x64 to 11.0 (matching aarch64) #1139
8308114: Bump minimum version of macOS for x64 to 11.0 (matching aarch64) #1139
Conversation
/reviewers 2 |
👋 Welcome back kcr! A progress list of the required criteria for merging this PR into |
@kevinrushforth |
There were no objections raised on the mailinglist, hence I am ok with bumping to 11.0 for JavaFX 21. |
@kevinrushforth This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
I'll wait 24 hours to integrate this in case other concerns are raised. |
/integrate |
@kevinrushforth Pushed as commit bff41c2. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
This PR bumps the minimum deployment target for JavaFX to macOS 11.0 (Big Sur) on x64 platforms, matching the current minimum on aarch64.
As a follow-on to this, I will file a (low-priority) cleanup issue to remove any
@available
checks for 10.x, since those will then be no-ops.Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx.git pull/1139/head:pull/1139
$ git checkout pull/1139
Update a local copy of the PR:
$ git checkout pull/1139
$ git pull https://git.openjdk.org/jfx.git pull/1139/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 1139
View PR using the GUI difftool:
$ git pr show -t 1139
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jfx/pull/1139.diff
Webrev
Link to Webrev Comment