-
Notifications
You must be signed in to change notification settings - Fork 471
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8310846: Skip failing test InitialWindowSizeTest on Linux #1162
Conversation
👋 Welcome back mstrauss! A progress list of the required criteria for merging this PR into |
I will try to fix it. |
Thanks. No hurry, though. It's been broken since JDK 8 (or earlier), and no one noticed until now. I'll assign that bug to you, but it won't be something we'll look at until after the jfx21 fork (so no earlier than jfx22). Since we will skip the failing test until it is fixed, part of the fix for that bug will be to remove the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good, and I verified that the test is now skipped on Linux.
@mstr2 This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
/integrate |
Going to push as commit d010d41. |
Skips
InitialWindowSizeTest
on Linux until JDK-8310845 is fixed.Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx.git pull/1162/head:pull/1162
$ git checkout pull/1162
Update a local copy of the PR:
$ git checkout pull/1162
$ git pull https://git.openjdk.org/jfx.git pull/1162/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 1162
View PR using the GUI difftool:
$ git pr show -t 1162
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jfx/pull/1162.diff
Webrev
Link to Webrev Comment