Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8310846: Skip failing test InitialWindowSizeTest on Linux #1162

Closed
wants to merge 1 commit into from

Conversation

mstr2
Copy link
Collaborator

@mstr2 mstr2 commented Jun 25, 2023

Skips InitialWindowSizeTest on Linux until JDK-8310845 is fixed.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8310846: Skip failing test InitialWindowSizeTest on Linux (Bug - P3)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx.git pull/1162/head:pull/1162
$ git checkout pull/1162

Update a local copy of the PR:
$ git checkout pull/1162
$ git pull https://git.openjdk.org/jfx.git pull/1162/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1162

View PR using the GUI difftool:
$ git pr show -t 1162

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jfx/pull/1162.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 25, 2023

👋 Welcome back mstrauss! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Ready for review label Jun 25, 2023
@mlbridge
Copy link

mlbridge bot commented Jun 25, 2023

Webrevs

@tsayao
Copy link
Collaborator

tsayao commented Jun 25, 2023

I will try to fix it.

@kevinrushforth kevinrushforth self-requested a review June 26, 2023 13:43
@kevinrushforth
Copy link
Member

I will try to fix it.

Thanks. No hurry, though. It's been broken since JDK 8 (or earlier), and no one noticed until now. I'll assign that bug to you, but it won't be something we'll look at until after the jfx21 fork (so no earlier than jfx22). Since we will skip the failing test until it is fixed, part of the fix for that bug will be to remove the assumeFalse added by this PR.

Copy link
Member

@kevinrushforth kevinrushforth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, and I verified that the test is now skipped on Linux.

@openjdk
Copy link

openjdk bot commented Jun 26, 2023

@mstr2 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8310846: Skip failing test InitialWindowSizeTest on Linux

Reviewed-by: kcr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Ready to be integrated label Jun 26, 2023
@mstr2
Copy link
Collaborator Author

mstr2 commented Jun 26, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Jun 26, 2023

Going to push as commit d010d41.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jun 26, 2023
@openjdk openjdk bot closed this Jun 26, 2023
@openjdk openjdk bot removed ready Ready to be integrated rfr Ready for review labels Jun 26, 2023
@openjdk
Copy link

openjdk bot commented Jun 26, 2023

@mstr2 Pushed as commit d010d41.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@mstr2 mstr2 deleted the fixes/JDK-8310846 branch June 27, 2023 02:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants