Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8309558: Create implementation of NSAccessibilityCheckBox protocol #1184

Closed
wants to merge 3 commits into from

Conversation

azuev-java
Copy link
Member

@azuev-java azuev-java commented Jul 23, 2023

also
8309629: Create implementation of NSAccessibilityRadioButton protocol

Create implementation of NSAccessibilityCheckBox and NSAccessibilityRadioButton protocols
Add workaround for the wrong focus owner announcement with radio buttons
Add workaround for wrong magnifier text on buttons


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed (2 reviews required, with at least 1 Reviewer, 1 Author)

Issues

  • JDK-8309558: Create implementation of NSAccessibilityCheckBox protocol (Enhancement - P3)
  • JDK-8309629: Create implementation of NSAccessibilityRadioButton protocol (Enhancement - P3)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx.git pull/1184/head:pull/1184
$ git checkout pull/1184

Update a local copy of the PR:
$ git checkout pull/1184
$ git pull https://git.openjdk.org/jfx.git pull/1184/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1184

View PR using the GUI difftool:
$ git pr show -t 1184

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jfx/pull/1184.diff

Webrev

Link to Webrev Comment

8309629: Create implementation of NSAccessibilityRadioButton protocol

Create implementation of NSAccessibilityCheckBox and NSAccessibilityRadioButton
protocols
Add workaround for the wrong focus owner announcement with radiobuttons
Add workaround for wrong magnifier text on buttons
@bridgekeeper
Copy link

bridgekeeper bot commented Jul 23, 2023

👋 Welcome back kizune! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@azuev-java
Copy link
Member Author

/issue add JDK-8309629

@openjdk openjdk bot added the rfr Ready for review label Jul 23, 2023
@openjdk
Copy link

openjdk bot commented Jul 23, 2023

@azuev-java
Adding additional issue to issue list: 8309629: Create implementation of NSAccessibilityRadioButton protocol.

@mlbridge
Copy link

mlbridge bot commented Jul 23, 2023

Webrevs

@kevinrushforth
Copy link
Member

/reviewers 2

@openjdk
Copy link

openjdk bot commented Jul 24, 2023

@kevinrushforth
The total number of required reviews for this PR (including the jcheck configuration and the last /reviewers command) is now set to 2 (with at least 1 Reviewer, 1 Author).

@kevinrushforth
Copy link
Member

Reviewers @arapte @kevinrushforth

Copy link
Member

@kevinrushforth kevinrushforth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes look good. I tested it on macOS 13.3.1 and VoiceOver output was as expected.

Copy link
Member

@arapte arapte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Providing a minor comment for a warning.
Also noticed that, with this change tab are read as radio button. [ Tested with ensemble ]

Screenshot 2023-08-06 at 3 23 35 PM

{
jobject jresult = NULL;
GET_MAIN_JENV;
if (env == NULL) return NULL;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This generates a warning:
warning: incompatible pointer to integer conversion returning 'void *' from a function with result type 'BOOL' (aka 'signed char') [-Wint-conversion]

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. This should probably be changed to: return NO;

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

Copy link
Member

@kevinrushforth kevinrushforth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also noticed that, with this change tab are read as radio button. [ Tested with ensemble ]

That seems like a bug.

{
jobject jresult = NULL;
GET_MAIN_JENV;
if (env == NULL) return NULL;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. This should probably be changed to: return NO;

@kevinrushforth kevinrushforth self-requested a review August 12, 2023 12:26
…he new API

Make isAccessibilityFocused to always return a proper value
@azuev-java
Copy link
Member Author

Providing a minor comment for a warning. Also noticed that, with this change tab are read as radio button. [ Tested with ensemble ]

Screenshot 2023-08-06 at 3 23 35 PM

That seems to require the proper implementation of TAB_GROUP with the new API - mixing old and new API does not work here since in the existing code the accessible type reported is radio button but because parent encloses them in a tab group content it gets translated as tab item. Changing type to tab item without implementing tab group makes it loose the "Tab x out of y" notion so it is not the correct way to go. Commented out that assignment until tab group is implemented.

Copy link
Member

@arapte arapte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openjdk
Copy link

openjdk bot commented Aug 16, 2023

@azuev-java This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8309558: Create implementation of NSAccessibilityCheckBox protocol
8309629: Create implementation of NSAccessibilityRadioButton protocol

Reviewed-by: kcr, arapte

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 20 new commits pushed to the master branch:

  • e5bb4e1: 8311983: ListView sometimes throws an IndexOutOfBoundsException
  • 72f05a7: 8307536: FileAlreadyExistsException from NativeLibLoader when running concurrent applications with empty cache
  • 5c3e832: 8310885: Width/height of window is not set after calling sizeToScene
  • 3b10562: 8314266: Several test failures after fix for JDK-8159048
  • 9e9c3b3: 8314149: Clipboard does inexact string comparison on mime type
  • c3257fc: 8159048: Animation and AnimationTimer methods must be called on JavaFX Application thread
  • a5183e5: 8283401: ArrayIndexOutOfBoundsException when disconnecting screen(s)
  • bedb964: 8307316: Let JavaFX be built on unknown architectures
  • 8998b2d: 8314141: Missing default for switch in CreateBitmap
  • 5d74176: 8313181: Enabling modern media controls on webkit 616.1 does not load button images on HTML5 video Element
  • ... and 10 more: https://git.openjdk.org/jfx/compare/ad5e66a7ca31994ecbdae3fc7d0b951e0a6f8197...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@kevinrushforth, @arapte) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Ready to be integrated label Aug 16, 2023
@azuev-java
Copy link
Member Author

/integrate

@openjdk openjdk bot added the sponsor Ready to sponsor label Aug 17, 2023
@openjdk
Copy link

openjdk bot commented Aug 17, 2023

@azuev-java
Your change (at version 8a6ad66) is now ready to be sponsored by a Committer.

@kevinrushforth
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Aug 17, 2023

Going to push as commit 7b797b9.
Since your change was applied there have been 20 commits pushed to the master branch:

  • e5bb4e1: 8311983: ListView sometimes throws an IndexOutOfBoundsException
  • 72f05a7: 8307536: FileAlreadyExistsException from NativeLibLoader when running concurrent applications with empty cache
  • 5c3e832: 8310885: Width/height of window is not set after calling sizeToScene
  • 3b10562: 8314266: Several test failures after fix for JDK-8159048
  • 9e9c3b3: 8314149: Clipboard does inexact string comparison on mime type
  • c3257fc: 8159048: Animation and AnimationTimer methods must be called on JavaFX Application thread
  • a5183e5: 8283401: ArrayIndexOutOfBoundsException when disconnecting screen(s)
  • bedb964: 8307316: Let JavaFX be built on unknown architectures
  • 8998b2d: 8314141: Missing default for switch in CreateBitmap
  • 5d74176: 8313181: Enabling modern media controls on webkit 616.1 does not load button images on HTML5 video Element
  • ... and 10 more: https://git.openjdk.org/jfx/compare/ad5e66a7ca31994ecbdae3fc7d0b951e0a6f8197...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 17, 2023
@openjdk openjdk bot closed this Aug 17, 2023
@openjdk openjdk bot removed the ready Ready to be integrated label Aug 17, 2023
@openjdk openjdk bot removed rfr Ready for review sponsor Ready to sponsor labels Aug 17, 2023
@openjdk
Copy link

openjdk bot commented Aug 17, 2023

@kevinrushforth @azuev-java Pushed as commit 7b797b9.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated
3 participants