Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8313227: Correct attenuation indicator for removed lights #1186

Conversation

nlisker
Copy link
Collaborator

@nlisker nlisker commented Jul 27, 2023

A simple fix of changing the attenuation toggle from 1 to 0 for removed lights.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8313227: Correct attenuation indicator for removed lights (Bug - P3)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx.git pull/1186/head:pull/1186
$ git checkout pull/1186

Update a local copy of the PR:
$ git checkout pull/1186
$ git pull https://git.openjdk.org/jfx.git pull/1186/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1186

View PR using the GUI difftool:
$ git pr show -t 1186

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jfx/pull/1186.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 27, 2023

👋 Welcome back nlisker! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Ready for review label Jul 27, 2023
@mlbridge
Copy link

mlbridge bot commented Jul 27, 2023

Webrevs

@nlisker
Copy link
Collaborator Author

nlisker commented Jul 27, 2023

@kevinrushforth I think that this is simple enough to be able to get into RDP1. There is some performance improvement regained here that was lost in one of my previous enhancements because of my mistake of setting this parameter to 1.

I think that 1 reviewer is enough.

By the way, the lighting in the LightingSample test application looks a bit off to me (regardless of this patch). It's as if the point and spot lights are too dim even at close range. Do you also notice that? Might need to look at previous revisions to see when it started,

@kevinrushforth kevinrushforth self-requested a review July 27, 2023 13:08
@kevinrushforth
Copy link
Member

@kevinrushforth I think that this is simple enough to be able to get into RDP1. There is some performance improvement regained here that was lost in one of my previous enhancements because of my mistake of setting this parameter to 1.

I think that 1 reviewer is enough.

Yes, I agree that a single reviewer should be fine. This seems a reasonable candidate to backport to jfx21 during RDP1 (no approval beyond the code review of the backport is needed).

By the way, the lighting in the LightingSample test application looks a bit off to me (regardless of this patch). It's as if the point and spot lights are too dim even at close range. Do you also notice that? Might need to look at previous revisions to see when it started,

I'll take a quick look on both Mac and Windows and let you know what I find.

@kevinrushforth
Copy link
Member

By the way, the lighting in the LightingSample test application looks a bit off to me (regardless of this patch). It's as if the point and spot lights are too dim even at close range. Do you also notice that? Might need to look at previous revisions to see when it started,

I'll take a quick look on both Mac and Windows and let you know what I find.

Without attenuation, it looks fine to me on both OpenGL and D3D. When I turn on attenuation, it seems like it is attenuated more quickly (and thus dimmer) than I might expect, but I can't be sure. It might be worth checking it against earlier versions (so might need to comment out SpotLight and DirectionalLight so you can go back far enough).

It's not related to this PR, though, so I'll approve it now.

@openjdk
Copy link

openjdk bot commented Jul 27, 2023

@nlisker This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8313227: Correct attenuation indicator for removed lights

Reviewed-by: kcr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Ready to be integrated label Jul 27, 2023
@nlisker
Copy link
Collaborator Author

nlisker commented Jul 27, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Jul 27, 2023

Going to push as commit b323db2.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jul 27, 2023
@openjdk openjdk bot closed this Jul 27, 2023
@openjdk openjdk bot removed ready Ready to be integrated rfr Ready for review labels Jul 27, 2023
@openjdk
Copy link

openjdk bot commented Jul 27, 2023

@nlisker Pushed as commit b323db2.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@nlisker nlisker deleted the 8313227_Correct_attenuation_indicator_for_removed_lights branch July 27, 2023 23:59
@nlisker
Copy link
Collaborator Author

nlisker commented Jul 27, 2023

/backport jfx jfx21

@openjdk
Copy link

openjdk bot commented Jul 28, 2023

@nlisker the backport was successfully created on the branch nlisker-backport-b323db26 in my personal fork of openjdk/jfx. To create a pull request with this backport targeting openjdk/jfx:jfx21, just click the following link:

➡️ Create pull request

The title of the pull request is automatically filled in correctly and below you find a suggestion for the pull request body:

Hi all,

This pull request contains a backport of commit b323db26 from the openjdk/jfx repository.

The commit being backported was authored by Nir Lisker on 27 Jul 2023 and was reviewed by Kevin Rushforth.

Thanks!

If you need to update the source branch of the pull then run the following commands in a local clone of your personal fork of openjdk/jfx:

$ git fetch https://github.com/openjdk-bots/jfx.git nlisker-backport-b323db26:nlisker-backport-b323db26
$ git checkout nlisker-backport-b323db26
# make changes
$ git add paths/to/changed/files
$ git commit --message 'Describe additional changes made'
$ git push https://github.com/openjdk-bots/jfx.git nlisker-backport-b323db26

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated
2 participants