Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8313227: Correct attenuation indicator for removed lights #1187

Closed

Conversation

nlisker
Copy link
Collaborator

@nlisker nlisker commented Jul 28, 2023

Backport of commit b323db26 (PR #1186)


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8313227: Correct attenuation indicator for removed lights (Bug - P3)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx.git pull/1187/head:pull/1187
$ git checkout pull/1187

Update a local copy of the PR:
$ git checkout pull/1187
$ git pull https://git.openjdk.org/jfx.git pull/1187/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1187

View PR using the GUI difftool:
$ git pr show -t 1187

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jfx/pull/1187.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 28, 2023

👋 Welcome back nlisker! A progress list of the required criteria for merging this PR into jfx21 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport b323db262906853afbdec7a747f3b2f5b6593b9b 8313227: Correct attenuation indicator for removed lights Jul 28, 2023
@openjdk
Copy link

openjdk bot commented Jul 28, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport clean rfr Ready for review labels Jul 28, 2023
@mlbridge
Copy link

mlbridge bot commented Jul 28, 2023

Webrevs

@openjdk
Copy link

openjdk bot commented Jul 28, 2023

@nlisker This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8313227: Correct attenuation indicator for removed lights

Reviewed-by: kcr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the jfx21 branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the jfx21 branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Ready to be integrated label Jul 28, 2023
@nlisker
Copy link
Collaborator Author

nlisker commented Jul 28, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Jul 28, 2023

Going to push as commit 86e7109.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jul 28, 2023
@openjdk openjdk bot closed this Jul 28, 2023
@openjdk openjdk bot removed ready Ready to be integrated rfr Ready for review labels Jul 28, 2023
@openjdk
Copy link

openjdk bot commented Jul 28, 2023

@nlisker Pushed as commit 86e7109.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
2 participants