Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8313177: Web Workers timeout with Webkit 616.1 #1191

Closed
wants to merge 3 commits into from

Conversation

jaybhaskar
Copy link
Member

@jaybhaskar jaybhaskar commented Jul 31, 2023

Issue: Some web worker tests fail to finish.
Root Cause:
sharedTimerFiredInternal function from ThreadTimers class does not require an isMainThread check, The check was introduced during the initial webkit stabilization.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed (2 reviews required, with at least 1 Reviewer, 1 Author)

Issue

  • JDK-8313177: Web Workers timeout with Webkit 616.1 (Bug - P2)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx.git pull/1191/head:pull/1191
$ git checkout pull/1191

Update a local copy of the PR:
$ git checkout pull/1191
$ git pull https://git.openjdk.org/jfx.git pull/1191/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1191

View PR using the GUI difftool:
$ git pr show -t 1191

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jfx/pull/1191.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 31, 2023

👋 Welcome back jbhaskar! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Ready for review label Jul 31, 2023
@mlbridge
Copy link

mlbridge bot commented Jul 31, 2023

Webrevs

@kevinrushforth kevinrushforth self-requested a review July 31, 2023 13:25
@kevinrushforth
Copy link
Member

@HimaBinduMeda Can you be the second reviewer?

/reviewers 2

@openjdk
Copy link

openjdk bot commented Jul 31, 2023

@kevinrushforth
The total number of required reviews for this PR (including the jcheck configuration and the last /reviewers command) is now set to 2 (with at least 1 Reviewer, 1 Author).

Copy link
Member

@kevinrushforth kevinrushforth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fix and test both look good. I confirm that it fixes the problem and that the new test fails without the fix and passes with the fix.

I left a couple minor comments on the test, but I'll approve it anyway. If you choose to fix them, I'll reapprove.

Copy link
Contributor

@HimaBinduMeda HimaBinduMeda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified the changes and internal testing looks fine. No issue observed.

@openjdk
Copy link

openjdk bot commented Aug 1, 2023

@jaybhaskar This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8313177: Web Workers timeout with Webkit 616.1

Reviewed-by: kcr, hmeda

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Ready to be integrated label Aug 1, 2023
@openjdk openjdk bot removed the ready Ready to be integrated label Aug 1, 2023
@openjdk openjdk bot added the ready Ready to be integrated label Aug 1, 2023
@jaybhaskar
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Aug 1, 2023

Going to push as commit 5f5e54f.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 1, 2023
@openjdk openjdk bot closed this Aug 1, 2023
@openjdk openjdk bot removed ready Ready to be integrated rfr Ready for review labels Aug 1, 2023
@openjdk
Copy link

openjdk bot commented Aug 1, 2023

@jaybhaskar Pushed as commit 5f5e54f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@jaybhaskar
Copy link
Member Author

/backport jfx21u

@openjdk
Copy link

openjdk bot commented Aug 2, 2023

@jaybhaskar the backport was successfully created on the branch jaybhaskar-backport-5f5e54fe in my personal fork of openjdk/jfx21u. To create a pull request with this backport targeting openjdk/jfx21u:master, just click the following link:

➡️ Create pull request

The title of the pull request is automatically filled in correctly and below you find a suggestion for the pull request body:

Hi all,

This pull request contains a backport of commit 5f5e54fe from the openjdk/jfx repository.

The commit being backported was authored by Jay Bhaskar on 1 Aug 2023 and was reviewed by Kevin Rushforth and Hima Bindu Meda.

Thanks!

If you need to update the source branch of the pull then run the following commands in a local clone of your personal fork of openjdk/jfx21u:

$ git fetch https://github.com/openjdk-bots/jfx21u.git jaybhaskar-backport-5f5e54fe:jaybhaskar-backport-5f5e54fe
$ git checkout jaybhaskar-backport-5f5e54fe
# make changes
$ git add paths/to/changed/files
$ git commit --message 'Describe additional changes made'
$ git push https://github.com/openjdk-bots/jfx21u.git jaybhaskar-backport-5f5e54fe

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated
3 participants