New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8237889: Update libxml2 to version 2.9.10 #120
Conversation
👋 Welcome back ajoseph! A progress list of the required criteria for merging this PR into |
Webrevs
|
/reviewers 2 |
@kevinrushforth |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I did a full build / test on Windows, and a full build on Mac and Linux.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Build + sanity tests are ok on win/mac/linux
@arun-joseph This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type
Since the source branch of this PR was last updated there have been 7 commits pushed to the As you do not have Committer status in this project, an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@kevinrushforth, @johanvos) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
This looks ok. I suggest to merge it sooner rather than later, so that we can create an EA built that has this code and have it tested. |
/integrate |
@arun-joseph |
/sponsor |
@kevinrushforth @arun-joseph The following commits have been pushed to master since your change was applied:
Your commit was automatically rebased without conflicts. Pushed as commit 4c132cd. |
Mailing list message from Kevin Rushforth on openjfx-dev: Changeset: 4c132cd 8237889: Update libxml2 to version 2.9.10 Reviewed-by: kcr, jvos ! modules/javafx.web/src/main/legal/libxml2.md |
We currently use libxml2 version 2.9.9. We should update to the latest stable release 2.9.10.
Progress
Issue
Reviewers
Download
$ git fetch https://git.openjdk.java.net/jfx pull/120/head:pull/120
$ git checkout pull/120