Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8237889: Update libxml2 to version 2.9.10 #120

Closed
wants to merge 2 commits into from

Conversation

@arun-Joseph
Copy link
Member

@arun-Joseph arun-Joseph commented Feb 21, 2020

We currently use libxml2 version 2.9.9. We should update to the latest stable release 2.9.10.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

Reviewers

  • Kevin Rushforth (kcr - Reviewer)
  • Johan Vos (jvos - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/jfx pull/120/head:pull/120
$ git checkout pull/120

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Feb 21, 2020

👋 Welcome back ajoseph! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request.

@openjdk openjdk bot added the rfr label Feb 21, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented Feb 21, 2020

Webrevs

@arun-Joseph arun-Joseph requested a review from kevinrushforth Feb 21, 2020
@kevinrushforth
Copy link
Member

@kevinrushforth kevinrushforth commented Feb 21, 2020

/reviewers 2

@openjdk
Copy link

@openjdk openjdk bot commented Feb 21, 2020

@kevinrushforth
The number of required reviews for this PR is now set to 2 (with at least 1 of role reviewers).

Copy link
Member

@kevinrushforth kevinrushforth left a comment

Looks good. I did a full build / test on Windows, and a full build on Mac and Linux.

@kevinrushforth
Copy link
Member

@kevinrushforth kevinrushforth commented Feb 25, 2020

@johanvos or @tiainen can one of you be the second reviewer? This isn't urgent, but we would like to get it in sometime in the next week or two.

Copy link
Collaborator

@johanvos johanvos left a comment

Build + sanity tests are ok on win/mac/linux

@openjdk
Copy link

@openjdk openjdk bot commented Feb 28, 2020

@arun-Joseph This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type /integrate in a new comment to proceed. After integration, the commit message will be:

8237889: Update libxml2 to version 2.9.10

Reviewed-by: kcr, jvos
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /solves command.

Since the source branch of this PR was last updated there have been 7 commits pushed to the master branch. Since there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge master into your branch, and then specify the current head hash when integrating, like this: /integrate 20328b38b836f2b0613da0aa46bd1f7d01f8fcd7.

As you do not have Committer status in this project, an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@kevinrushforth, @johanvos) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready label Feb 28, 2020
@johanvos
Copy link
Collaborator

@johanvos johanvos commented Feb 28, 2020

This looks ok. I suggest to merge it sooner rather than later, so that we can create an EA built that has this code and have it tested.

@arun-Joseph
Copy link
Member Author

@arun-Joseph arun-Joseph commented Mar 1, 2020

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Mar 1, 2020

@arun-Joseph
Your change (at version 9c76239) is now ready to be sponsored by a Committer.

@openjdk openjdk bot added the sponsor label Mar 1, 2020
@kevinrushforth
Copy link
Member

@kevinrushforth kevinrushforth commented Mar 2, 2020

/sponsor

@openjdk openjdk bot closed this Mar 2, 2020
@openjdk openjdk bot added integrated and removed sponsor ready labels Mar 2, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Mar 2, 2020

@kevinrushforth @arun-Joseph The following commits have been pushed to master since your change was applied:

  • 20328b3: 8240218: IOS Webkit implementation broken
  • 4c82af8: 8236832: [macos 10.15] JavaFX Application hangs on video play on Cata…
  • 9cd6f79: 8196586: Remove use of deprecated finalize methods from javafx property objects
  • ef2f9ce: 8238755: allow to create static lib for javafx.media on linux
  • c3ee1a3: 8239822: Intermittent unit test failures in RegionCSSTest
  • 3150562: 8235772: Remove use of deprecated finalize method from PiscesRenderer and AbstractSurface
  • 4eaff0d: 8239109: Update SQLite to version 3.31.1

Your commit was automatically rebased without conflicts.

Pushed as commit 4c132cd.

@openjdk openjdk bot removed the rfr label Mar 2, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented Mar 2, 2020

Mailing list message from Kevin Rushforth on openjfx-dev:

Changeset: 4c132cd
Author: Arun Joseph <ajoseph at openjdk.org>
Committer: Kevin Rushforth <kcr at openjdk.org>
Date: 2020-03-02 13:04:20 +0000
URL: https://git.openjdk.java.net/jfx/commit/4c132cdf

8237889: Update libxml2 to version 2.9.10

Reviewed-by: kcr, jvos

! modules/javafx.web/src/main/legal/libxml2.md
! modules/javafx.web/src/main/native/Source/ThirdParty/libxml/linux/config.h
! modules/javafx.web/src/main/native/Source/ThirdParty/libxml/linux/include/libxml/xmlversion.h
! modules/javafx.web/src/main/native/Source/ThirdParty/libxml/mac/config.h
! modules/javafx.web/src/main/native/Source/ThirdParty/libxml/mac/include/libxml/xmlversion.h
! modules/javafx.web/src/main/native/Source/ThirdParty/libxml/src/ChangeLog
! modules/javafx.web/src/main/native/Source/ThirdParty/libxml/src/HTMLparser.c
! modules/javafx.web/src/main/native/Source/ThirdParty/libxml/src/HTMLtree.c
! modules/javafx.web/src/main/native/Source/ThirdParty/libxml/src/Makefile.am
! modules/javafx.web/src/main/native/Source/ThirdParty/libxml/src/NEWS
! modules/javafx.web/src/main/native/Source/ThirdParty/libxml/src/README
! modules/javafx.web/src/main/native/Source/ThirdParty/libxml/src/README.zOS
! modules/javafx.web/src/main/native/Source/ThirdParty/libxml/src/SAX2.c
! modules/javafx.web/src/main/native/Source/ThirdParty/libxml/src/aclocal.m4
! modules/javafx.web/src/main/native/Source/ThirdParty/libxml/src/buf.c
! modules/javafx.web/src/main/native/Source/ThirdParty/libxml/src/configure.ac
! modules/javafx.web/src/main/native/Source/ThirdParty/libxml/src/dict.c
! modules/javafx.web/src/main/native/Source/ThirdParty/libxml/src/elfgcchack.h
! modules/javafx.web/src/main/native/Source/ThirdParty/libxml/src/enc.h
! modules/javafx.web/src/main/native/Source/ThirdParty/libxml/src/encoding.c
! modules/javafx.web/src/main/native/Source/ThirdParty/libxml/src/entities.c
! modules/javafx.web/src/main/native/Source/ThirdParty/libxml/src/error.c
! modules/javafx.web/src/main/native/Source/ThirdParty/libxml/src/globals.c
! modules/javafx.web/src/main/native/Source/ThirdParty/libxml/src/hash.c
! modules/javafx.web/src/main/native/Source/ThirdParty/libxml/src/include/libxml/c14n.h
! modules/javafx.web/src/main/native/Source/ThirdParty/libxml/src/include/libxml/catalog.h
! modules/javafx.web/src/main/native/Source/ThirdParty/libxml/src/include/libxml/dict.h
! modules/javafx.web/src/main/native/Source/ThirdParty/libxml/src/include/libxml/hash.h
! modules/javafx.web/src/main/native/Source/ThirdParty/libxml/src/include/libxml/parser.h
! modules/javafx.web/src/main/native/Source/ThirdParty/libxml/src/include/libxml/parserInternals.h
! modules/javafx.web/src/main/native/Source/ThirdParty/libxml/src/include/libxml/schemasInternals.h
! modules/javafx.web/src/main/native/Source/ThirdParty/libxml/src/include/libxml/tree.h
! modules/javafx.web/src/main/native/Source/ThirdParty/libxml/src/include/libxml/xlink.h
! modules/javafx.web/src/main/native/Source/ThirdParty/libxml/src/include/libxml/xmlIO.h
! modules/javafx.web/src/main/native/Source/ThirdParty/libxml/src/include/libxml/xmlerror.h
! modules/javafx.web/src/main/native/Source/ThirdParty/libxml/src/include/libxml/xmlexports.h
! modules/javafx.web/src/main/native/Source/ThirdParty/libxml/src/include/libxml/xmlversion.h.in
! modules/javafx.web/src/main/native/Source/ThirdParty/libxml/src/include/libxml/xpath.h
! modules/javafx.web/src/main/native/Source/ThirdParty/libxml/src/include/win32config.h
! modules/javafx.web/src/main/native/Source/ThirdParty/libxml/src/include/wsockcompat.h
! modules/javafx.web/src/main/native/Source/ThirdParty/libxml/src/libxml.h
! modules/javafx.web/src/main/native/Source/ThirdParty/libxml/src/libxml.spec.in
! modules/javafx.web/src/main/native/Source/ThirdParty/libxml/src/libxml2.spec
! modules/javafx.web/src/main/native/Source/ThirdParty/libxml/src/libxml2.syms
! modules/javafx.web/src/main/native/Source/ThirdParty/libxml/src/nanohttp.c
! modules/javafx.web/src/main/native/Source/ThirdParty/libxml/src/parser.c
! modules/javafx.web/src/main/native/Source/ThirdParty/libxml/src/parserInternals.c
! modules/javafx.web/src/main/native/Source/ThirdParty/libxml/src/pattern.c
! modules/javafx.web/src/main/native/Source/ThirdParty/libxml/src/save.h
! modules/javafx.web/src/main/native/Source/ThirdParty/libxml/src/threads.c
! modules/javafx.web/src/main/native/Source/ThirdParty/libxml/src/timsort.h
! modules/javafx.web/src/main/native/Source/ThirdParty/libxml/src/tree.c
! modules/javafx.web/src/main/native/Source/ThirdParty/libxml/src/trionan.c
! modules/javafx.web/src/main/native/Source/ThirdParty/libxml/src/uri.c
! modules/javafx.web/src/main/native/Source/ThirdParty/libxml/src/valid.c
! modules/javafx.web/src/main/native/Source/ThirdParty/libxml/src/win32/Makefile.bcb
! modules/javafx.web/src/main/native/Source/ThirdParty/libxml/src/win32/Makefile.mingw
! modules/javafx.web/src/main/native/Source/ThirdParty/libxml/src/win32/Makefile.msvc
! modules/javafx.web/src/main/native/Source/ThirdParty/libxml/src/win32/configure.js
! modules/javafx.web/src/main/native/Source/ThirdParty/libxml/src/win32/libxml2.def.src
! modules/javafx.web/src/main/native/Source/ThirdParty/libxml/src/xml2-config.1
! modules/javafx.web/src/main/native/Source/ThirdParty/libxml/src/xml2Conf.sh.in
! modules/javafx.web/src/main/native/Source/ThirdParty/libxml/src/xmlIO.c
! modules/javafx.web/src/main/native/Source/ThirdParty/libxml/src/xmlreader.c
! modules/javafx.web/src/main/native/Source/ThirdParty/libxml/src/xmlsave.c
! modules/javafx.web/src/main/native/Source/ThirdParty/libxml/src/xmlwriter.c
! modules/javafx.web/src/main/native/Source/ThirdParty/libxml/src/xpath.c
! modules/javafx.web/src/main/native/Source/ThirdParty/libxml/src/xzlib.h
! modules/javafx.web/src/main/native/Source/ThirdParty/libxml/win32/config.h
! modules/javafx.web/src/main/native/Source/ThirdParty/libxml/win32/include/libxml/xmlversion.h

@arun-Joseph arun-Joseph deleted the arun-Joseph:8237889 branch Mar 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.