Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8313181: Enabling modern media controls on webkit 616.1 does not load button images on HTML5 video Element #1201

Closed
wants to merge 5 commits into from

Conversation

jaybhaskar
Copy link
Member

@jaybhaskar jaybhaskar commented Aug 6, 2023

Issue : Enabling modern media controls on webkit 616.1 does not load button images on HTML5 Video Element
Solution: Add resources and correct MediaControl Stylesheet


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed (2 reviews required, with at least 1 Reviewer, 1 Author)

Issue

  • JDK-8313181: Enabling modern media controls on webkit 616.1 does not load button images on HTML5 video Element (Bug - P3)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx.git pull/1201/head:pull/1201
$ git checkout pull/1201

Update a local copy of the PR:
$ git checkout pull/1201
$ git pull https://git.openjdk.org/jfx.git pull/1201/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1201

View PR using the GUI difftool:
$ git pr show -t 1201

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jfx/pull/1201.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 6, 2023

👋 Welcome back jbhaskar! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Ready for review label Aug 6, 2023
@mlbridge
Copy link

mlbridge bot commented Aug 6, 2023

Webrevs

@kevinrushforth
Copy link
Member

Reviewers: @kevinrushforth @HimaBinduMeda

/reviewers 2

@kevinrushforth kevinrushforth self-requested a review August 7, 2023 23:11
@openjdk
Copy link

openjdk bot commented Aug 7, 2023

@kevinrushforth
The total number of required reviews for this PR (including the jcheck configuration and the last /reviewers command) is now set to 2 (with at least 1 Reviewer, 1 Author).

Copy link
Member

@kevinrushforth kevinrushforth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this on Windows and confirm that the media controls are visible and active now. I left a few inline comments on the test and the utility script.

Copy link
Member

@kevinrushforth kevinrushforth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The updates look good with two remaining comments.

Here is the screen shot that shows the clipping in the example test program.

HTML5VideoControlTest

Copy link
Contributor

@HimaBinduMeda HimaBinduMeda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look fine. Internal testing looks fine.

@openjdk
Copy link

openjdk bot commented Aug 9, 2023

@jaybhaskar This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8313181: Enabling modern media controls on webkit 616.1 does not load button images on HTML5 video Element

Reviewed-by: kcr, hmeda

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4 new commits pushed to the master branch:

  • 9f180e2: 8313900: Possible NULL pointer access in NativeAudioSpectrum and NativeVideoBuffer
  • 771273f: 8313799: Remove lockItemOnEdit flag from (Tree)TableCell
  • 1752b62: 8313856: Replace VLA with malloc in pango
  • af8950e: 8313711: Cherry-pick WebKit 616.1 stabilization fixes

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Ready to be integrated label Aug 9, 2023
@jaybhaskar
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Aug 9, 2023

Going to push as commit 5d74176.
Since your change was applied there have been 4 commits pushed to the master branch:

  • 9f180e2: 8313900: Possible NULL pointer access in NativeAudioSpectrum and NativeVideoBuffer
  • 771273f: 8313799: Remove lockItemOnEdit flag from (Tree)TableCell
  • 1752b62: 8313856: Replace VLA with malloc in pango
  • af8950e: 8313711: Cherry-pick WebKit 616.1 stabilization fixes

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 9, 2023
@openjdk openjdk bot closed this Aug 9, 2023
@openjdk openjdk bot removed ready Ready to be integrated rfr Ready for review labels Aug 9, 2023
@openjdk
Copy link

openjdk bot commented Aug 9, 2023

@jaybhaskar Pushed as commit 5d74176.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@jaybhaskar
Copy link
Member Author

/backport jfx21u

@openjdk
Copy link

openjdk bot commented Aug 9, 2023

@jaybhaskar the backport was successfully created on the branch jaybhaskar-backport-5d741761 in my personal fork of openjdk/jfx21u. To create a pull request with this backport targeting openjdk/jfx21u:master, just click the following link:

➡️ Create pull request

The title of the pull request is automatically filled in correctly and below you find a suggestion for the pull request body:

Hi all,

This pull request contains a backport of commit 5d741761 from the openjdk/jfx repository.

The commit being backported was authored by Jay Bhaskar on 9 Aug 2023 and was reviewed by Kevin Rushforth and Hima Bindu Meda.

Thanks!

If you need to update the source branch of the pull then run the following commands in a local clone of your personal fork of openjdk/jfx21u:

$ git fetch https://github.com/openjdk-bots/jfx21u.git jaybhaskar-backport-5d741761:jaybhaskar-backport-5d741761
$ git checkout jaybhaskar-backport-5d741761
# make changes
$ git add paths/to/changed/files
$ git commit --message 'Describe additional changes made'
$ git push https://github.com/openjdk-bots/jfx21u.git jaybhaskar-backport-5d741761

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated
3 participants