8313900: Possible NULL pointer access in NativeAudioSpectrum and NativeVideoBuffer

[sashamatveev]

• Fixed by checking for NULL pointer after memory allocation.
• In NativeVideoBuffer std::nothrow was added when allocating jint array, so new will return NULL instead of throwing exception. This done for consistency and also it is not clear how well JNI handles C++ exceptions in this case and what value will Java code get if exception is thrown.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed (2 reviews required, with at least 1 Reviewer, 1 Author)

Issue

• JDK-8313900: Possible NULL pointer access in NativeAudioSpectrum and NativeVideoBuffer (Bug - P3)

Reviewers

• Kevin Rushforth (@kevinrushforth - Reviewer)
• Ambarish Rapte (@arapte - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx.git pull/1204/head:pull/1204
$ git checkout pull/1204

Update a local copy of the PR:
$ git checkout pull/1204
$ git pull https://git.openjdk.org/jfx.git pull/1204/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1204

View PR using the GUI difftool:
$ git pr show -t 1204

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jfx/pull/1204.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back almatvee! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[mlbridge]

Webrevs

• 00: Full (96b054fc)

[kevinrushforth]

Reviewers: @kevinrushforth @arapte

/reviewers 2

[openjdk]

@kevinrushforth
The total number of required reviews for this PR (including the jcheck configuration and the last /reviewers command) is now set to 2 (with at least 1 Reviewer, 1 Author).

[kevinrushforth]

LGTM

[openjdk]

@sashamatveev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8313900: Possible NULL pointer access in NativeAudioSpectrum and NativeVideoBuffer

Reviewed-by: kcr, arapte

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

• 771273f: 8313799: Remove lockItemOnEdit flag from (Tree)TableCell
• 1752b62: 8313856: Replace VLA with malloc in pango

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[sashamatveev]

/integrate

[openjdk]

Going to push as commit 9f180e2.
Since your change was applied there have been 2 commits pushed to the master branch:

• 771273f: 8313799: Remove lockItemOnEdit flag from (Tree)TableCell
• 1752b62: 8313856: Replace VLA with malloc in pango

Your commit was automatically rebased without conflicts.

[openjdk]

@sashamatveev Pushed as commit 9f180e2.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.