Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8314141: Missing default for switch in CreateBitmap #1206

Closed
wants to merge 1 commit into from

Conversation

arapte
Copy link
Member

@arapte arapte commented Aug 11, 2023

This is a simple change to add a missing default statement.
@kevinrushforth @jayathirthrao please review.
/reviewers 2


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed (2 reviews required, with at least 1 Reviewer, 1 Author)

Issue

  • JDK-8314141: Missing default for switch in CreateBitmap (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx.git pull/1206/head:pull/1206
$ git checkout pull/1206

Update a local copy of the PR:
$ git checkout pull/1206
$ git pull https://git.openjdk.org/jfx.git pull/1206/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1206

View PR using the GUI difftool:
$ git pr show -t 1206

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jfx/pull/1206.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 11, 2023

👋 Welcome back arapte! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Ready for review label Aug 11, 2023
@openjdk
Copy link

openjdk bot commented Aug 11, 2023

@arapte
The total number of required reviews for this PR (including the jcheck configuration and the last /reviewers command) is now set to 2 (with at least 1 Reviewer, 1 Author).

@mlbridge
Copy link

mlbridge bot commented Aug 11, 2023

Webrevs

@openjdk
Copy link

openjdk bot commented Aug 11, 2023

@arapte This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8314141: Missing default for switch in CreateBitmap

Reviewed-by: jdv, jhendrikx, kcr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Ready to be integrated label Aug 11, 2023
@arapte
Copy link
Member Author

arapte commented Aug 11, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Aug 11, 2023

Going to push as commit 8998b2d.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 11, 2023
@openjdk openjdk bot closed this Aug 11, 2023
@openjdk openjdk bot removed ready Ready to be integrated rfr Ready for review labels Aug 11, 2023
@openjdk
Copy link

openjdk bot commented Aug 11, 2023

@arapte Pushed as commit 8998b2d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated
4 participants