Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

8314149: Clipboard does inexact string comparison on mime type #1207

Closed
wants to merge 2 commits into from

Conversation

arapte
Copy link
Member

@arapte arapte commented Aug 11, 2023

The mime name should be exactly same as the mime type supported by platform.
Hence the comparison should not match partially similar names.
Added an invalid unit test.

@kevinrushforth @jayathirthrao please review

/reviewers 2


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed (2 reviews required, with at least 1 Reviewer, 1 Author)

Issue

  • JDK-8314149: Clipboard does inexact string comparison on mime type (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx.git pull/1207/head:pull/1207
$ git checkout pull/1207

Update a local copy of the PR:
$ git checkout pull/1207
$ git pull https://git.openjdk.org/jfx.git pull/1207/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1207

View PR using the GUI difftool:
$ git pr show -t 1207

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jfx/pull/1207.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 11, 2023

馃憢 Welcome back arapte! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Ready for review label Aug 11, 2023
@openjdk
Copy link

openjdk bot commented Aug 11, 2023

@arapte
The total number of required reviews for this PR (including the jcheck configuration and the last /reviewers command) is now set to 2 (with at least 1 Reviewer, 1 Author).

@mlbridge
Copy link

mlbridge bot commented Aug 11, 2023

Webrevs

Copy link
Member

@kevinrushforth kevinrushforth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code change looks good. However, the new test passes for me either with or without your fix.

@kevinrushforth kevinrushforth self-requested a review August 12, 2023 12:25
@arapte
Copy link
Member Author

arapte commented Aug 14, 2023

The code change looks good. However, the new test passes for me either with or without your fix.

Hi Kevin, I re-looked into the test. The test seems to be insufficient to test the change.
That test and other test in the file ClipboardContentTest, only verify if there are expected entries in the ClipboardContent map and does not verify whole copy functionality to the level of system clipboard, hence removed the test.
I think adding a test that verifies this may be an overkill for the change we are making here and would like to skip adding a test. Does that sound ok ?

@kevinrushforth
Copy link
Member

I think adding a test that verifies this may be an overkill for the change we are making here and would like to skip adding a test. Does that sound ok ?

Yes, that seems fine. Please add an appropriate "noreg-" label to the JBS bug (e.g., "noreg-hard").

Copy link
Member

@kevinrushforth kevinrushforth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good.

Copy link
Collaborator

@mstr2 mstr2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openjdk
Copy link

openjdk bot commented Aug 15, 2023

@arapte This change now passes all automated pre-integration checks.

鈩癸笍 This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8314149: Clipboard does inexact string comparison on mime type

Reviewed-by: jdv, kcr, mstrauss

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4 new commits pushed to the master branch:

  • c3257fc: 8159048: Animation and AnimationTimer methods must be called on JavaFX Application thread
  • a5183e5: 8283401: ArrayIndexOutOfBoundsException when disconnecting screen(s)
  • bedb964: 8307316: Let JavaFX be built on unknown architectures
  • 8998b2d: 8314141: Missing default for switch in CreateBitmap

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

鉃★笍 To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Ready to be integrated label Aug 15, 2023
@arapte
Copy link
Member Author

arapte commented Aug 16, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Aug 16, 2023

Going to push as commit 9e9c3b3.
Since your change was applied there have been 4 commits pushed to the master branch:

  • c3257fc: 8159048: Animation and AnimationTimer methods must be called on JavaFX Application thread
  • a5183e5: 8283401: ArrayIndexOutOfBoundsException when disconnecting screen(s)
  • bedb964: 8307316: Let JavaFX be built on unknown architectures
  • 8998b2d: 8314141: Missing default for switch in CreateBitmap

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 16, 2023
@openjdk openjdk bot closed this Aug 16, 2023
@openjdk openjdk bot removed ready Ready to be integrated rfr Ready for review labels Aug 16, 2023
@openjdk
Copy link

openjdk bot commented Aug 16, 2023

@arapte Pushed as commit 9e9c3b3.

馃挕 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated
5 participants