Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8314212: Crash when loading cnn.com in WebView #1212

Closed
wants to merge 2 commits into from

Conversation

jaybhaskar
Copy link
Member

@jaybhaskar jaybhaskar commented Aug 17, 2023

Issue: WCMediaPlayer does not support HTTP live streaming m3u8 format. Giving error com.sun.javafx.webkit.prism.WCMediaPlayerImpl onError WARNING: onError, errCode=0, msg=Unsupported protocol "data"

Solution: Do not invoke the current media time operation in an error state. As the WCMediaPlayer might not be a valid object.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed (2 reviews required, with at least 1 Reviewer, 1 Author)

Issue

  • JDK-8314212: Crash when loading cnn.com in WebView (Bug - P2)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx.git pull/1212/head:pull/1212
$ git checkout pull/1212

Update a local copy of the PR:
$ git checkout pull/1212
$ git pull https://git.openjdk.org/jfx.git pull/1212/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1212

View PR using the GUI difftool:
$ git pr show -t 1212

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jfx/pull/1212.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 17, 2023

👋 Welcome back jbhaskar! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Ready for review label Aug 17, 2023
@mlbridge
Copy link

mlbridge bot commented Aug 17, 2023

Webrevs

@jaybhaskar jaybhaskar changed the title 8314212: FxWebNodeRendering : Test "sites/cnn.com.html" is Crashing the WebView 8314212: FxWebNodeRendering Test "sites/cnn.com.html" is Crashing the WebView Aug 17, 2023
@kevinrushforth
Copy link
Member

@jaybhaskar I changed the JBS bug title to something more reflective of the problem, so you'll need to edit this PR title to match.

/reviewers 2

@openjdk
Copy link

openjdk bot commented Aug 17, 2023

@kevinrushforth
The total number of required reviews for this PR (including the jcheck configuration and the last /reviewers command) is now set to 2 (with at least 1 Reviewer, 1 Author).

@jaybhaskar jaybhaskar changed the title 8314212: FxWebNodeRendering Test "sites/cnn.com.html" is Crashing the WebView 8314212: Crash when loading cnn.com in WebView Aug 17, 2023
Copy link
Member

@kevinrushforth kevinrushforth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left one question about the fix (and also noted a couple minor formatting issues).

I presume you've tested this on all platforms both with media that produces the error condition, and also verifying that valid media continues to play correctly?

@kevinrushforth
Copy link
Member

@HimaBinduMeda Can you be the second reviewer?

@jaybhaskar
Copy link
Member Author

jaybhaskar commented Aug 17, 2023

I have tested on mac/Linux/Window cnn page is working fine , no crash observed

Copy link
Contributor

@HimaBinduMeda HimaBinduMeda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look fine. Testing looks good.

Copy link
Member

@kevinrushforth kevinrushforth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes look good. All my testing is green.

@openjdk
Copy link

openjdk bot commented Aug 18, 2023

@jaybhaskar This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8314212: Crash when loading cnn.com in WebView

Reviewed-by: kcr, hmeda

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 7 new commits pushed to the master branch:

  • 7b797b9: 8309558: Create implementation of NSAccessibilityCheckBox protocol
  • e5bb4e1: 8311983: ListView sometimes throws an IndexOutOfBoundsException
  • 72f05a7: 8307536: FileAlreadyExistsException from NativeLibLoader when running concurrent applications with empty cache
  • 5c3e832: 8310885: Width/height of window is not set after calling sizeToScene
  • 3b10562: 8314266: Several test failures after fix for JDK-8159048
  • 9e9c3b3: 8314149: Clipboard does inexact string comparison on mime type
  • c3257fc: 8159048: Animation and AnimationTimer methods must be called on JavaFX Application thread

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Ready to be integrated label Aug 18, 2023
@jaybhaskar
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Aug 18, 2023

Going to push as commit ddd1f79.
Since your change was applied there have been 7 commits pushed to the master branch:

  • 7b797b9: 8309558: Create implementation of NSAccessibilityCheckBox protocol
  • e5bb4e1: 8311983: ListView sometimes throws an IndexOutOfBoundsException
  • 72f05a7: 8307536: FileAlreadyExistsException from NativeLibLoader when running concurrent applications with empty cache
  • 5c3e832: 8310885: Width/height of window is not set after calling sizeToScene
  • 3b10562: 8314266: Several test failures after fix for JDK-8159048
  • 9e9c3b3: 8314149: Clipboard does inexact string comparison on mime type
  • c3257fc: 8159048: Animation and AnimationTimer methods must be called on JavaFX Application thread

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 18, 2023
@openjdk openjdk bot closed this Aug 18, 2023
@openjdk openjdk bot removed ready Ready to be integrated rfr Ready for review labels Aug 18, 2023
@openjdk
Copy link

openjdk bot commented Aug 18, 2023

@jaybhaskar Pushed as commit ddd1f79.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@jaybhaskar
Copy link
Member Author

/backport jfx21u

@openjdk
Copy link

openjdk bot commented Aug 18, 2023

@jaybhaskar the backport was successfully created on the branch jaybhaskar-backport-ddd1f796 in my personal fork of openjdk/jfx21u. To create a pull request with this backport targeting openjdk/jfx21u:master, just click the following link:

➡️ Create pull request

The title of the pull request is automatically filled in correctly and below you find a suggestion for the pull request body:

Hi all,

This pull request contains a backport of commit ddd1f796 from the openjdk/jfx repository.

The commit being backported was authored by Jay Bhaskar on 18 Aug 2023 and was reviewed by Kevin Rushforth and Hima Bindu Meda.

Thanks!

If you need to update the source branch of the pull then run the following commands in a local clone of your personal fork of openjdk/jfx21u:

$ git fetch https://github.com/openjdk-bots/jfx21u.git jaybhaskar-backport-ddd1f796:jaybhaskar-backport-ddd1f796
$ git checkout jaybhaskar-backport-ddd1f796
# make changes
$ git add paths/to/changed/files
$ git commit --message 'Describe additional changes made'
$ git push https://github.com/openjdk-bots/jfx21u.git jaybhaskar-backport-ddd1f796

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated
3 participants