8315870: icu fails to compile with Visual Studio 2022 17.6.5

[kevinrushforth]

Fix icu to compile with the latest VS 2022 compilers. Note that this fix is already present in the upstream ICU repo. See unicode-org/icu@c7e967c

I've built this using the current compilers on all three platforms, and on Windows using VS 2022 17.6.5.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8315870: icu fails to compile with Visual Studio 2022 17.6.5 (Bug - P3)

Reviewers

• Ambarish Rapte (@arapte - Reviewer)
• Johan Vos (@johanvos - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx.git pull/1235/head:pull/1235
$ git checkout pull/1235

Update a local copy of the PR:
$ git checkout pull/1235
$ git pull https://git.openjdk.org/jfx.git pull/1235/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1235

View PR using the GUI difftool:
$ git pr show -t 1235

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jfx/pull/1235.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back kcr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[kevinrushforth]

Reviewers: @arapte @jaybhaskar

@tiainen @johanvos Did you also want to do a test build on your end (I can't imagine it would cause a problem, but wanted to give you a chance to comment).

[mlbridge]

Webrevs

• 00: Full (2a24e621)

[openjdk]

@kevinrushforth This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8315870: icu fails to compile with Visual Studio 2022 17.6.5

Reviewed-by: arapte, jvos

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[johanvos]

Tested with the required compilers, and didn't run into problems.
Didn't test with VS 2022 17.6.5 though but most important is that we don't have regression with the required compilers, hence +1

[kevinrushforth]

Didn't test with VS 2022 17.6.5 though but most important is that we don't have regression with the required compilers...

My thoughts exactly.

[kevinrushforth]

/integrate

[openjdk]

Going to push as commit ed92171.

[openjdk]

@kevinrushforth Pushed as commit ed92171.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.