Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8310666: gradle validateSourceSets task not run when TEST_ONLY=true #1237

Closed
wants to merge 1 commit into from

Conversation

arapte
Copy link
Member

@arapte arapte commented Sep 11, 2023

The validateSourceSets task are created only for the test tasks. check source
So, validateSourceSets task must be executed when running test tasks even when TEST_ONLY=true.
This had caused a regression JDK-8310654, where we missed a failing scenario as validateSourceSets did not run with -PTEST_ONLY=true


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8310666: gradle validateSourceSets task not run when TEST_ONLY=true (Bug - P3)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx.git pull/1237/head:pull/1237
$ git checkout pull/1237

Update a local copy of the PR:
$ git checkout pull/1237
$ git pull https://git.openjdk.org/jfx.git pull/1237/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1237

View PR using the GUI difftool:
$ git pr show -t 1237

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jfx/pull/1237.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 11, 2023

👋 Welcome back arapte! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Ready for review label Sep 11, 2023
@mlbridge
Copy link

mlbridge bot commented Sep 11, 2023

Webrevs

Copy link
Member

@kevinrushforth kevinrushforth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. One suggestion, possibly for a follow-up enhancement, would be to move all of the logic to isTestTask. As part of this, you could consider documenting and treating validate and/or verify as prefixes that are treated as test tasks.

@openjdk
Copy link

openjdk bot commented Sep 11, 2023

@arapte This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8310666: gradle validateSourceSets task not run when TEST_ONLY=true

Reviewed-by: kcr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Ready to be integrated label Sep 11, 2023
@arapte
Copy link
Member Author

arapte commented Sep 11, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Sep 11, 2023

Going to push as commit 325be56.

@openjdk openjdk bot added the integrated Pull request has been integrated label Sep 11, 2023
@openjdk openjdk bot closed this Sep 11, 2023
@openjdk openjdk bot removed ready Ready to be integrated rfr Ready for review labels Sep 11, 2023
@openjdk
Copy link

openjdk bot commented Sep 11, 2023

@arapte Pushed as commit 325be56.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated
2 participants