Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
8239822: Intermittent unit test failures in RegionCSSTest #124
This is a fix for an intermittent test failure affecting
Except for the systemTests project, all unit tests are run in the same JVM, so each test class must ensure that any modified global state is restored after the tests are run. The CssStyleHelperTest leaves a userAgentStyleSheet set, which is a global (per Application) attribute, so any subsequent tests will be run with that stylesheet set. If the last test that is run in CssStyleHelperTest sets a style sheet with
The fix is to cleanup the global userAgentStyleSheet, along with any other state that is set, in an
Thanks for pointing that out. In addition to
I'll update the PR to fix the above two.
I looked further, and see that the following tests call
This is a slightly different case, and none of these are causing problems today, so I will file a follow-up test bug to look at those and see if they need cleanup.
@kevinrushforth This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type
Since the source branch of this PR was last updated there have been 2 commits pushed to the
@kevinrushforth The following commits have been pushed to master since your change was applied:
Your commit was automatically rebased without conflicts.
Pushed as commit c3ee1a3.
8239822: Intermittent unit test failures in RegionCSSTest