Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8255079: RobotTest::testPixelCaptureAverage fails intermittently on Windows with HiDPI scaling #1242

Closed

Conversation

lukostyra
Copy link
Contributor

@lukostyra lukostyra commented Sep 15, 2023

The instability came from the way Windows sets window's default position. When it is not predefined on Stage creation (which was the case in these Robot tests) the window is created at some arbitrary position chosen by Windows near top-left corner. It also seems like Windows first picks the position assuming 100% scaling and then multiplies it by UI scale, which can provide X/Y coordinates of Stage with a fractional value.

Due to above behavior, there is a chance that the fractional part of X/Y will be above .5 which fails the test (X/Y values were fetched via casting directly to int, which drops the fractional part without rounding). Adding rounding makes the test always pass and the assumption in the comment below consistent.

unstable.test property check was removed, since this change stabilizes the test and its results.

Verified also on macOS to ensure the change did not affect the tests.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8255079: RobotTest::testPixelCaptureAverage fails intermittently on Windows with HiDPI scaling (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx.git pull/1242/head:pull/1242
$ git checkout pull/1242

Update a local copy of the PR:
$ git checkout pull/1242
$ git pull https://git.openjdk.org/jfx.git pull/1242/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1242

View PR using the GUI difftool:
$ git pr show -t 1242

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jfx/pull/1242.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 15, 2023

👋 Welcome back lkostyra! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Ready for review label Sep 15, 2023
@mlbridge
Copy link

mlbridge bot commented Sep 15, 2023

Webrevs

Copy link
Member

@kevinrushforth kevinrushforth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. The test is now stable on my Windows 10 system using 125% scaling.

@openjdk
Copy link

openjdk bot commented Sep 15, 2023

@lukostyra This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8255079: RobotTest::testPixelCaptureAverage fails intermittently on Windows with HiDPI scaling

Reviewed-by: kcr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4 new commits pushed to the master branch:

  • 5e145cc: 8199216: Quadratic layout time with nested nodes and pseudo-class in style sheet
  • f185974: 8251240: Menus inaccessible on Linux with i3 wm
  • f7b21e5: 8315074: Possible null pointer access in native glass
  • 7c8dd1e: 8315958: Missing range checks in GlassPasteboard

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Ready to be integrated label Sep 15, 2023
@lukostyra
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Sep 18, 2023

Going to push as commit 2ae8c27.
Since your change was applied there have been 4 commits pushed to the master branch:

  • 5e145cc: 8199216: Quadratic layout time with nested nodes and pseudo-class in style sheet
  • f185974: 8251240: Menus inaccessible on Linux with i3 wm
  • f7b21e5: 8315074: Possible null pointer access in native glass
  • 7c8dd1e: 8315958: Missing range checks in GlassPasteboard

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Sep 18, 2023
@openjdk openjdk bot closed this Sep 18, 2023
@openjdk openjdk bot removed ready Ready to be integrated rfr Ready for review labels Sep 18, 2023
@openjdk
Copy link

openjdk bot commented Sep 18, 2023

@lukostyra Pushed as commit 2ae8c27.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@lukostyra lukostyra deleted the robot_unstable_get_color-8255079 branch September 18, 2023 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated
2 participants