Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8316892: Skip failing IconifyTestcanIconifyDecoratedStage on Linux #1250

Closed

Conversation

lukostyra
Copy link
Contributor

@lukostyra lukostyra commented Sep 28, 2023

Failing test is skipped. Verified on Ubuntu VM.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8316892: Skip failing IconifyTestcanIconifyDecoratedStage on Linux (Bug - P3)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx.git pull/1250/head:pull/1250
$ git checkout pull/1250

Update a local copy of the PR:
$ git checkout pull/1250
$ git pull https://git.openjdk.org/jfx.git pull/1250/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1250

View PR using the GUI difftool:
$ git pr show -t 1250

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jfx/pull/1250.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 28, 2023

👋 Welcome back lkostyra! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Ready for review label Sep 28, 2023
@mlbridge
Copy link

mlbridge bot commented Sep 28, 2023

Webrevs

@tsayao
Copy link
Collaborator

tsayao commented Sep 28, 2023

It seems windows do get iconified, but the bottom window is iconified as well.

@kevinrushforth
Copy link
Member

It seems windows do get iconified, but the bottom window is iconified as well.

Do you mean it fails for you consistently? Or do you also see it fail intermittently, and when it does, both are iconified?

@openjdk
Copy link

openjdk bot commented Sep 28, 2023

@lukostyra This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8316892: Skip failing IconifyTestcanIconifyDecoratedStage on Linux

Reviewed-by: kcr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Ready to be integrated label Sep 28, 2023
@tsayao
Copy link
Collaborator

tsayao commented Sep 28, 2023

I forgot I was on Wayland. It passes 100% on Xorg / Ubuntu 22.04.

@lukostyra
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Sep 29, 2023

Going to push as commit 1733d2e.

@openjdk openjdk bot added the integrated Pull request has been integrated label Sep 29, 2023
@openjdk openjdk bot closed this Sep 29, 2023
@openjdk openjdk bot removed ready Ready to be integrated rfr Ready for review labels Sep 29, 2023
@openjdk
Copy link

openjdk bot commented Sep 29, 2023

@lukostyra Pushed as commit 1733d2e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@lukostyra lukostyra deleted the skip_iconify_test-8316892 branch November 28, 2023 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated
3 participants