Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8317508: Provide media support for libavcodec version 60 #1259

Closed
wants to merge 1 commit into from

Conversation

sashamatveev
Copy link
Member

@sashamatveev sashamatveev commented Oct 13, 2023

  • Added support for libavcodec version 60.
  • Tested on Ubuntu 23.10 with all possible media formats.
  • Changed "--disable-yasm" to "--disable-asm". "--disable-asm" disables all assembler optimization and "--disable-yasm" only x86. Without "--disable-asm" I had issue building ffmpeg 6.0 on Ubuntu 23.10 most likely due to compiler version. Disabling assembler optimization fixed issue and we do not need this anyway for our stubs.

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed (2 reviews required, with at least 1 Reviewer, 1 Author)

Issue

  • JDK-8317508: Provide media support for libavcodec version 60 (Bug - P3)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx.git pull/1259/head:pull/1259
$ git checkout pull/1259

Update a local copy of the PR:
$ git checkout pull/1259
$ git pull https://git.openjdk.org/jfx.git pull/1259/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1259

View PR using the GUI difftool:
$ git pr show -t 1259

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jfx/pull/1259.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 13, 2023

👋 Welcome back almatvee! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Ready for review label Oct 13, 2023
@mlbridge
Copy link

mlbridge bot commented Oct 13, 2023

Webrevs

@victordyakov
Copy link
Collaborator

victordyakov commented Oct 16, 2023

@arapte please review

@kevinrushforth
Copy link
Member

/reviewers 2

@openjdk
Copy link

openjdk bot commented Oct 17, 2023

@kevinrushforth
The total number of required reviews for this PR (including the jcheck configuration and the last /reviewers command) is now set to 2 (with at least 1 Reviewer, 1 Author).

Copy link
Collaborator

@tiainen tiainen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds and tests ran successfully.

@openjdk
Copy link

openjdk bot commented Oct 18, 2023

@sashamatveev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8317508: Provide media support for libavcodec version 60

Reviewed-by: sykora, arapte

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 7 new commits pushed to the master branch:

  • bb07bcf: 8313321: Set minimum python version in WebKit cmake scripts
  • cd7383a: 8318204: Use new EventTarget methods in ListenerHelper
  • 1616924: 8317370: JavaFX runtime version is wrong at runtime
  • 6d2595a: 8318115: Webkit build fails after gradle 8.4
  • f76437d: 8314906: [testbug] Create behavior tests for text input controls
  • 4604e87: 8318059: Typo is javafx.scene.Node.usesMirroring comment
  • e621d4b: 8314484: Update Gradle to 8.4

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Ready to be integrated label Oct 18, 2023
@sashamatveev
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Oct 19, 2023

Going to push as commit de456da.
Since your change was applied there have been 8 commits pushed to the master branch:

  • 27594f0: 8315569: Tests for the contract of SkinBase.layoutChildren(..)
  • bb07bcf: 8313321: Set minimum python version in WebKit cmake scripts
  • cd7383a: 8318204: Use new EventTarget methods in ListenerHelper
  • 1616924: 8317370: JavaFX runtime version is wrong at runtime
  • 6d2595a: 8318115: Webkit build fails after gradle 8.4
  • f76437d: 8314906: [testbug] Create behavior tests for text input controls
  • 4604e87: 8318059: Typo is javafx.scene.Node.usesMirroring comment
  • e621d4b: 8314484: Update Gradle to 8.4

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 19, 2023
@openjdk openjdk bot closed this Oct 19, 2023
@openjdk openjdk bot removed ready Ready to be integrated rfr Ready for review labels Oct 19, 2023
@openjdk
Copy link

openjdk bot commented Oct 19, 2023

@sashamatveev Pushed as commit de456da.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated
5 participants