Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8236832: [macos 10.15] JavaFX Application hangs on video play on Cata… #126

Closed
wants to merge 1 commit into from

Conversation

@sashamatveev
Copy link
Member

sashamatveev commented Feb 26, 2020

https://bugs.openjdk.java.net/browse/JDK-8236832

  • This issue most likely caused by changes in AVFoundation APIs on macOS 10.15.
  • Getting currentTime from AVPlayer was blocked if it is done from ProcessAudioTap callback (used for spectrum, equalizer and volume) on first call. If we reading currentTime after first callback returns, then it will not block. Fixed by not reading currentTime on first call and default it 0.

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8236832: [macos 10.15] JavaFX Application hangs on video play on Catalina

Reviewers

  • Kevin Rushforth (kcr - Reviewer)
  • Guru Hb (ghb - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/jfx pull/126/head:pull/126
$ git checkout pull/126

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 26, 2020

👋 Welcome back almatvee! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request.

@openjdk openjdk bot added the rfr label Feb 26, 2020
@mlbridge
Copy link

mlbridge bot commented Feb 26, 2020

Webrevs

Copy link
Member

kevinrushforth left a comment

Looks good to me.

I think this is a safe enough change that a single reviewer will be sufficient, although we should wait for one day to see if anyone else has comments.

@openjdk
Copy link

openjdk bot commented Feb 26, 2020

@sashamatveev This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type /integrate in a new comment to proceed. After integration, the commit message will be:

8236832: [macos 10.15] JavaFX Application hangs on video play on Cata…

Reviewed-by: kcr, ghb
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /solves command.

Since the source branch of this PR was last updated there have been 2 commits pushed to the master branch. Since there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge master into your branch, and then specify the current head hash when integrating, like this: /integrate 4c82af8df124c07fdc439c679f5453caecd11f2e.

➡️ To integrate this PR with the above commit message, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Feb 26, 2020
@kevinrushforth
Copy link
Member

kevinrushforth commented Feb 26, 2020

I tested this on both macOS 10.15.2 (Catalina) and macOS t0.13.6 (High Sierra) and everything looks good.

@guruhb
guruhb approved these changes Feb 27, 2020
Copy link
Collaborator

guruhb left a comment

+1, Looks good to me.

@sashamatveev
Copy link
Member Author

sashamatveev commented Feb 28, 2020

/integrate

@openjdk openjdk bot closed this Feb 28, 2020
@openjdk openjdk bot added integrated and removed ready labels Feb 28, 2020
@openjdk
Copy link

openjdk bot commented Feb 28, 2020

@sashamatveev The following commits have been pushed to master since your change was applied:

  • 9cd6f79: 8196586: Remove use of deprecated finalize methods from javafx property objects

Your commit was automatically rebased without conflicts.

Pushed as commit 4c82af8.

@openjdk openjdk bot removed the rfr label Feb 28, 2020
@mlbridge
Copy link

mlbridge bot commented Feb 28, 2020

Mailing list message from Alexander Matveev on openjfx-dev:

Changeset: 4c82af8
Author: Alexander Matveev <almatvee at openjdk.org>
Date: 2020-02-28 05:07:50 +0000
URL: https://git.openjdk.java.net/jfx/commit/4c82af8d

8236832: [macos 10.15] JavaFX Application hangs on video play on Cata?

Reviewed-by: kcr, ghb

! modules/javafx.media/src/main/native/jfxmedia/platform/osx/avf/AVFAudioProcessor.mm
! modules/javafx.media/src/main/native/jfxmedia/platform/osx/avf/AVFAudioSpectrumUnit.cpp
! modules/javafx.media/src/main/native/jfxmedia/platform/osx/avf/AVFAudioSpectrumUnit.h
! modules/javafx.media/src/main/native/jfxmedia/platform/osx/avf/AVFMediaPlayer.mm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.