Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8318059: Typo is javafx.scene.Node.usesMirroring comment #1260

Closed
wants to merge 1 commit into from

Conversation

prsadhuk
Copy link
Collaborator

@prsadhuk prsadhuk commented Oct 13, 2023

Corrected the typo


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8318059: Typo is javafx.scene.Node.usesMirroring comment (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx.git pull/1260/head:pull/1260
$ git checkout pull/1260

Update a local copy of the PR:
$ git checkout pull/1260
$ git pull https://git.openjdk.org/jfx.git pull/1260/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1260

View PR using the GUI difftool:
$ git pr show -t 1260

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jfx/pull/1260.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 13, 2023

👋 Welcome back psadhukhan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Ready for review label Oct 13, 2023
@mlbridge
Copy link

mlbridge bot commented Oct 13, 2023

Webrevs

@prsadhuk prsadhuk changed the title 8318059: Typo is javafx.scene.Mode.usesMirroring comment 8318059: Typo is javafx.scene.Node.usesMirroring comment Oct 13, 2023
Copy link
Collaborator

@aghaisas aghaisas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@openjdk
Copy link

openjdk bot commented Oct 13, 2023

@prsadhuk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8318059: Typo is javafx.scene.Node.usesMirroring comment

Reviewed-by: aghaisas

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 7 new commits pushed to the master branch:

  • e621d4b: 8314484: Update Gradle to 8.4
  • 73e690f: 8314486: JavaFX build uses deprecated features that will be removed in gradle 8
  • ec9a11b: 8316590: Rendering artifact after JDK-8311983
  • 2ec3343: 8313628: Column drag header, overlay and line are not correctly aligned
  • 2586278: 8317308: JavaFX Developer build broken on Windows - NativeLibrary file contains invalid character ':'
  • 1733d2e: 8316892: Skip failing IconifyTestcanIconifyDecoratedStage on Linux
  • f2dd4bd: 8315657: Application window not activated in macOS 14 Sonoma

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Ready to be integrated label Oct 13, 2023
@prsadhuk
Copy link
Collaborator Author

/integrate

@openjdk
Copy link

openjdk bot commented Oct 13, 2023

Going to push as commit 4604e87.
Since your change was applied there have been 7 commits pushed to the master branch:

  • e621d4b: 8314484: Update Gradle to 8.4
  • 73e690f: 8314486: JavaFX build uses deprecated features that will be removed in gradle 8
  • ec9a11b: 8316590: Rendering artifact after JDK-8311983
  • 2ec3343: 8313628: Column drag header, overlay and line are not correctly aligned
  • 2586278: 8317308: JavaFX Developer build broken on Windows - NativeLibrary file contains invalid character ':'
  • 1733d2e: 8316892: Skip failing IconifyTestcanIconifyDecoratedStage on Linux
  • f2dd4bd: 8315657: Application window not activated in macOS 14 Sonoma

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 13, 2023
@openjdk openjdk bot closed this Oct 13, 2023
@openjdk openjdk bot removed ready Ready to be integrated rfr Ready for review labels Oct 13, 2023
@openjdk
Copy link

openjdk bot commented Oct 13, 2023

@prsadhuk Pushed as commit 4604e87.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@prsadhuk prsadhuk deleted the typo-fix branch October 13, 2023 03:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated
2 participants