Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8319231: Unrecognized "minimum" key in .jcheck/conf causes /reviewers command to be ignored #1275

Closed
wants to merge 1 commit into from

Conversation

kevinrushforth
Copy link
Member

@kevinrushforth kevinrushforth commented Nov 1, 2023

A recent change to Skara in processing of the .jcheck/conf file (SKARA-2080) introduced a bug in processing the [checks "reviewers"] section that causes the /reviewers command to be ignored in some cases. This is tracked by SKARA-2088. The reason we tripped over this bug is that the .jcheck/conf file used by jfx (including various update release repos) uses an unrecognized key, "minimum", instead of the expected "reviewers" key to indicate the minimum number of reviewers. We should fix this to be consistent with what Skara expects given the intent of our [checks "reviewers"] section.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8319231: Unrecognized "minimum" key in .jcheck/conf causes /reviewers command to be ignored (Bug - P2)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx.git pull/1275/head:pull/1275
$ git checkout pull/1275

Update a local copy of the PR:
$ git checkout pull/1275
$ git pull https://git.openjdk.org/jfx.git pull/1275/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1275

View PR using the GUI difftool:
$ git pr show -t 1275

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jfx/pull/1275.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 1, 2023

👋 Welcome back kcr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@kevinrushforth
Copy link
Member Author

@edvbld Can you review this?

@andy-goryachev-oracle Can you be the "R"eviewer (once Erik D reviews it)?

@openjdk openjdk bot added the rfr Ready for review label Nov 1, 2023
@kevinrushforth
Copy link
Member Author

NOTE: This matches the equivalent line in the jdk repo's .jcheck/conf' file.

@mlbridge
Copy link

mlbridge bot commented Nov 1, 2023

Webrevs

Copy link
Member

@edvbld edvbld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Copy link
Contributor

@andy-goryachev-oracle andy-goryachev-oracle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

matches jdk!

@openjdk
Copy link

openjdk bot commented Nov 1, 2023

@kevinrushforth This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8319231: Unrecognized "minimum" key in .jcheck/conf causes /reviewers command to be ignored

Reviewed-by: ehelin, angorya

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Ready to be integrated label Nov 1, 2023
@kevinrushforth
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Nov 1, 2023

Going to push as commit 72c052e.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 1, 2023
@openjdk openjdk bot closed this Nov 1, 2023
@openjdk openjdk bot removed ready Ready to be integrated rfr Ready for review labels Nov 1, 2023
@openjdk
Copy link

openjdk bot commented Nov 1, 2023

@kevinrushforth Pushed as commit 72c052e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@kevinrushforth kevinrushforth deleted the 8319231-jcheck branch November 1, 2023 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated
3 participants