Skip to content

8318388: Update libxslt to 1.1.39#1298

Closed
HimaBinduMeda wants to merge 7 commits intoopenjdk:masterfrom
HimaBinduMeda:libxslt-1.39
Closed

8318388: Update libxslt to 1.1.39#1298
HimaBinduMeda wants to merge 7 commits intoopenjdk:masterfrom
HimaBinduMeda:libxslt-1.39

Conversation

@HimaBinduMeda
Copy link
Contributor

@HimaBinduMeda HimaBinduMeda commented Nov 29, 2023

Updated libxslt to v1.1.39. Verified build on all platforms.No issue seen.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed (2 reviews required, with at least 1 Reviewer, 1 Author)

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx.git pull/1298/head:pull/1298
$ git checkout pull/1298

Update a local copy of the PR:
$ git checkout pull/1298
$ git pull https://git.openjdk.org/jfx.git pull/1298/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1298

View PR using the GUI difftool:
$ git pr show -t 1298

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jfx/pull/1298.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 29, 2023

👋 Welcome back hmeda! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@HimaBinduMeda HimaBinduMeda changed the title Draft :Libxslt 1.39 Draft :8318388:Update libxslt to 1.1.39 Nov 29, 2023
@HimaBinduMeda HimaBinduMeda changed the title Draft :8318388:Update libxslt to 1.1.39 8318388:Update libxslt to 1.1.39 Nov 29, 2023
@HimaBinduMeda HimaBinduMeda marked this pull request as ready for review November 29, 2023 16:41
@HimaBinduMeda HimaBinduMeda changed the title 8318388:Update libxslt to 1.1.39 8318388: Update libxslt to 1.1.39 Nov 29, 2023
@openjdk openjdk bot added the rfr Ready for review label Nov 29, 2023
@mlbridge
Copy link

mlbridge bot commented Nov 29, 2023

Webrevs

@HimaBinduMeda HimaBinduMeda changed the title 8318388: Update libxslt to 1.1.39 Draft: 8318388: Update libxslt to 1.1.39 Nov 29, 2023
@openjdk openjdk bot removed the rfr Ready for review label Nov 29, 2023
@HimaBinduMeda HimaBinduMeda changed the title Draft: 8318388: Update libxslt to 1.1.39 8318388: Update libxslt to 1.1.39 Nov 30, 2023
@openjdk openjdk bot added the rfr Ready for review label Nov 30, 2023
@kevinrushforth
Copy link
Member

Reviewers: @kevinrushforth @johanvos @tiainen

/reviewers 2

@openjdk
Copy link

openjdk bot commented Dec 1, 2023

@kevinrushforth
The total number of required reviews for this PR (including the jcheck configuration and the last /reviewers command) is now set to 2 (with at least 1 Reviewer, 1 Author).

Copy link
Member

@kevinrushforth kevinrushforth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@openjdk
Copy link

openjdk bot commented Dec 5, 2023

@HimaBinduMeda This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8318388: Update libxslt to 1.1.39

Reviewed-by: kcr, sykora

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 7 new commits pushed to the master branch:

  • aedc887: 8320359: ImageView: add styleable fitWidth, fitHeight, preserveRatio, smooth properties
  • 092d5d2: 8314597: Deprecate for removal protected access methods in converters
  • 036d81b: 8269921: TextFlow: listeners on bounds can throw NPE while computing text bounds
  • 0d33417: 8320267: WebView crashes on macOS 11 with WebKit 616.1
  • d65d8a6: 8316518: javafx.print.Paper getWidth / getHeight rounds values, causing errors.
  • c46c172: 8320773: [macOS] All IME input blocked
  • b80ec39: 8313648: JavaFX application continues to show a black screen after graphic card driver crash

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Ready to be integrated label Dec 5, 2023
@HimaBinduMeda
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Dec 5, 2023

Going to push as commit 09922d5.
Since your change was applied there have been 7 commits pushed to the master branch:

  • aedc887: 8320359: ImageView: add styleable fitWidth, fitHeight, preserveRatio, smooth properties
  • 092d5d2: 8314597: Deprecate for removal protected access methods in converters
  • 036d81b: 8269921: TextFlow: listeners on bounds can throw NPE while computing text bounds
  • 0d33417: 8320267: WebView crashes on macOS 11 with WebKit 616.1
  • d65d8a6: 8316518: javafx.print.Paper getWidth / getHeight rounds values, causing errors.
  • c46c172: 8320773: [macOS] All IME input blocked
  • b80ec39: 8313648: JavaFX application continues to show a black screen after graphic card driver crash

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 5, 2023
@openjdk openjdk bot closed this Dec 5, 2023
@openjdk openjdk bot removed ready Ready to be integrated rfr Ready for review labels Dec 5, 2023
@openjdk
Copy link

openjdk bot commented Dec 5, 2023

@HimaBinduMeda Pushed as commit 09922d5.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

3 participants