Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8232158: [macOS] Fallback to command line tools if xcode is missing #13

Closed

Conversation

@arajkumar
Copy link
Contributor

arajkumar commented Oct 11, 2019

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

JDK-8232158: [macOS] Fallback to command line tools if xcode is missing

Approvers

  • Kevin Rushforth (kcr - Reviewer)
  • Johan Vos (jvos - Reviewer)
@bridgekeeper
Copy link

bridgekeeper bot commented Oct 11, 2019

Hi arajkumar, welcome to this OpenJDK project and thanks for contributing!

We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing /signed in a comment in this pull request.

If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user arajkumar" as summary for the issue.

If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing /covered in a comment in this pull request.

@bridgekeeper bridgekeeper bot added the oca label Oct 11, 2019
@arajkumar arajkumar changed the title JDK-8232158: [macOS] Fallback to command line tools if xcode is missing 8232158: [macOS] Fallback to command line tools if xcode is missing Oct 11, 2019
@arajkumar
Copy link
Contributor Author

arajkumar commented Oct 11, 2019

/signed

@bridgekeeper bridgekeeper bot added the oca-verify label Oct 11, 2019
@bridgekeeper
Copy link

bridgekeeper bot commented Oct 11, 2019

Thank you! Please allow for up to two weeks to process your OCA, although it is usually done within one to two business days. Also, please note that pull requests that are pending an OCA check will not usually be evaluated, so your patience is appreciated!

@openjdk openjdk bot added the rfr label Oct 11, 2019
@mlbridge
Copy link

mlbridge bot commented Oct 11, 2019

Webrevs

Signed-off-by: Arunprasad Rajkumar <ar.arunprasad@gmail.com>
@arajkumar arajkumar force-pushed the arajkumar:build-using-xcode-cmd-tools branch from 063d2f3 to 9b1f728 Oct 11, 2019
@arajkumar
Copy link
Contributor Author

arajkumar commented Oct 16, 2019

@kevinrushforth Am I missing anything here which prevents the review process?

@kevinrushforth
Copy link
Member

kevinrushforth commented Oct 16, 2019

No, I have just been swamped the last few days. It's on my list to review. Sorry for the delay.

@arajkumar
Copy link
Contributor Author

arajkumar commented Oct 16, 2019

Thanks @kevinrushforth.

@kevinrushforth kevinrushforth self-requested a review Oct 21, 2019
Copy link
Member

kevinrushforth left a comment

Looks good. This one is simple enough I don't think it needs a second review, although @johanvos might want to review it.

@openjdk openjdk bot removed the rfr label Oct 21, 2019
@openjdk
Copy link

openjdk bot commented Oct 21, 2019

@arajkumar This change can now be integrated. The commit message will be:

8232158: [macOS] Fallback to command line tools if xcode is missing

Reviewed-by: kcr, jvos
  • If you would like to add a summary, use the /summary command.
  • To list additional contributors, use the /contributor command.

Since the source branch of this PR was last updated there have been 16 commits pushed to the master branch:

Since there are no conflicts, your changes will automatically be rebased on top of the above commits when integrating. If you prefer to do this manually, please merge master into your branch first.

  • To integrate this PR with the above commit message, type /integrate in a new comment.
@openjdk openjdk bot added the ready label Oct 21, 2019
@arajkumar
Copy link
Contributor Author

arajkumar commented Oct 22, 2019

@johanvos , Do you have any concern? In short, this fix allows developers to build jfx on mac without full Xcode install. It would be useful for CI/CD.

@johanvos johanvos self-requested a review Oct 23, 2019
Copy link
Collaborator

johanvos left a comment

These things (retrieving locations and versions of OS-specific directories/settings and toolchains) are imho the most brittle of the whole end-to-end building. Mistakes here (e.g. wrong versions, wrong architectures) might lead to a number of almost inpredictable failures.
I 100% agree the fallback is a great idea, but I am a bit worried that this change is in gradle and that we don't have tests for this.

@arajkumar
Copy link
Contributor Author

arajkumar commented Oct 23, 2019

/integrate

@openjdk openjdk bot closed this Oct 23, 2019
@openjdk openjdk bot added integrated and removed ready labels Oct 23, 2019
@openjdk
Copy link

openjdk bot commented Oct 23, 2019

@arajkumar The following commits have been pushed to master since your change was applied:

Your commit was automatically rebased without conflicts.

Pushed as commit ab6ea3b.

@mlbridge
Copy link

mlbridge bot commented Oct 23, 2019

Mailing list message from Arunprasad Rajkumar arajkumar@openjdk.org

Changeset: ab6ea3b
Author: Arunprasad Rajkumar
Date: 2019-10-23 08:41:40 +0000
URL: https://git.openjdk.java.net/jfx/commit/ab6ea3b9

8232158: [macOS] Fallback to command line tools if xcode is missing

Reviewed-by: kcr, jvos

! buildSrc/mac.gradle

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.