8240262: iOS refresh rate is capped to 30 Hz

[jperedadnr]

There is a hardcoded limit to refresh the glass view on iOS at a half rate of the native refresh rate.

This PR removes that limit.

Since the default value for frameInterval is 1 (which implies refreshing at the same rate as allowed by the device), doing setFrameInterval:1 is not necessary. What's more, this method is deprecated.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8240262: iOS refresh rate is capped to 30 Hz

Reviewers

• Johan Vos (jvos - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/jfx pull/130/head:pull/130
$ git checkout pull/130

[bridgekeeper]

👋 Welcome back jpereda! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request.

[mlbridge]

Webrevs

• 00: Full (892f6d5)

[johanvos]

The only thing that worries me is that I don't see a reason why this limitation was added originally.
I don't see a reason to keep it, so +1 on removing it.

[openjdk]

@jperedadnr This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type /integrate in a new comment to proceed. After integration, the commit message will be:

8240262: iOS refresh rate is capped to 30 Hz

Reviewed-by: jvos

• If you would like to add a summary, use the /summary command.
• To credit additional contributors, use the /contributor command.
• To add additional solved issues, use the /solves command.

Since the source branch of this PR was last updated there have been 34 commits pushed to the master branch. Since there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge master into your branch, and then specify the current head hash when integrating, like this: /integrate 3f663e3771a32828942a95b738fadcd7dd7bfa8b.

As you do not have Committer status in this project, an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@johanvos) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[jperedadnr]

/integrate

[openjdk]

@jperedadnr Your merge request cannot be fulfilled at this time, as the status check jcheck did not complete successfully

[kevinrushforth]

Btw, the jcheck failure is because JBS is down. This revealed a bug in the Skara jcheck bot where it doesn't handle it gracefully (so considers it a failure).

As soon as JBS is back up or the Skara bot is fixed, this will proceed.

[johanvos]

/sponsor

[openjdk]

@johanvos The change author (@jperedadnr) must issue an integrate command before the integration can be sponsored.

[jperedadnr]

/integrate

[openjdk]

@jperedadnr
Your change (at version 892f6d5) is now ready to be sponsored by a Committer.

[johanvos]

/sponsor

[openjdk]

@johanvos @jperedadnr The following commits have been pushed to master since your change was applied:

• 231879a: 8241710: NullPointerException while entering empty submenu with "arrow right"
• 470c7d0: 8230809: HTMLEditor formatting lost when selecting all (CTRL-A)
• fda015c: 8242167: ios keyboard handling
• 844460b: 8242163: Android keyboard integration fails
• 364c64a: 8241249: NPE in TabPaneSkin.perfromDrag
• 418675a: 8236840: Memory leak when switching ButtonSkin
• 247a65d: 8236971: [macos] Gestures handled incorrectly due to missing events
• 560ef17: 8241455: Memory leak on replacing selection/focusModel
• 5906521: 8241370: Crash in JPEGImageLoader after fix for JDK-8212034
• 159f651: 8240542: Switch FX build to use JDK 14 as boot JDK
• 6d098fe: 8234959: FXMLLoader does not populate ENGINE_SCOPE Bindings with FILENAME and ARGV
• d7f13f4: 8089828: RTL Orientation, the flag of a mnemonic is not placed under the mnemonic letter.
• 9ecc107: 8240539: Upgrade gradle to version 6.3
• f3a3ea0: 8234471: Canvas in webview displayed with wrong scale on Windows
• d12e71c: 8241474: Build failing on Ubuntu 20.04
• 2a7ab36: 8089134: [2D traversal, RTL] TraversalEngine only handles left/right key traversal correctly in RTL for top-level engine in ToolBar
• 2aa8218: 8235480: Regression: [RTL] Arrow keys navigation doesn't respect TableView orientation
• e9c6119: 8240692: Cleanup of the javafx property objects
• 90289a2: 8239107: Update libjpeg to version 9d
• b81cf32: 8236259: MemoryLeak in ProgressIndicator
• 9ea7f96: 8240832: Remove unused applecoreaudio.md third-party legal file
• 0fc1420: Merge
• 50e15fc: 8240466: AppJSCallback* apps launched by ModuleLauncherTest intermittently hang
• e3026b9: 8240688: Remove the JavaBeanXxxPropertyBuilders constructors
• f8c235b: 8240631: Create release notes for JavaFX 14
• cfa1193: 8236685: [macOs] Remove obsolete file dialog subclasses
• f25e8cf: 8212034: Potential memory leaks in jpegLoader.c in error case
• b2ac76a: 8240451: JavaFX javadoc build fails with JDK 14
• cf0bba6: 8240211: Stack overflow on Windows 32-bit can lead to crash
• 337ed72: 8237926: Potential memory leak of model data in javafx.scene.control.ListView
• 960f039: 8208761: Update constant collections to use the new immutable collections
• 10c9528: 8240265: iOS: Unnecessary logging on pinch gestures
• 4c132cd: 8237889: Update libxml2 to version 2.9.10

Your commit was automatically rebased without conflicts.

Pushed as commit 3f663e3.