Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8321636: [testbug] Skip failing 3D lighting tests on macOS 14 / aarch64 #1303

Conversation

kevinrushforth
Copy link
Member

@kevinrushforth kevinrushforth commented Dec 11, 2023

Until JDK-8318985 is fixed, we will skip the 4 failing 3D light tests on Mac / aarch64 if the macOS version is 14, meaning they will not be run as part of our nightly headful test runs or developer test build.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8321636: [testbug] Skip failing 3D lighting tests on macOS 14 / aarch64 (Bug - P3)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx.git pull/1303/head:pull/1303
$ git checkout pull/1303

Update a local copy of the PR:
$ git checkout pull/1303
$ git pull https://git.openjdk.org/jfx.git pull/1303/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1303

View PR using the GUI difftool:
$ git pr show -t 1303

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jfx/pull/1303.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 11, 2023

👋 Welcome back kcr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Ready for review label Dec 11, 2023
@mlbridge
Copy link

mlbridge bot commented Dec 11, 2023

Webrevs

@@ -66,9 +67,17 @@ public class PointLightIlluminationTest extends VisualTestBase {
private static final double COLOR_TOLERANCE = 0.07;
private static volatile Scene testScene = null;

// Used to skip failing tests until JDK-8318985 is fixed
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we probably should add a note in JDK-8318985 description so we won't forget to revert these changes.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea. I added a comment to that JBS bug.

@openjdk
Copy link

openjdk bot commented Dec 11, 2023

@kevinrushforth This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8321636: [testbug] Skip failing 3D lighting tests on macOS 14 / aarch64

Reviewed-by: angorya

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Ready to be integrated label Dec 11, 2023
@kevinrushforth
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Dec 11, 2023

Going to push as commit b389f6d.
Since your change was applied there has been 1 commit pushed to the master branch:

  • 60476ef: 8321573: Improve Platform.Preferences documentation

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 11, 2023
@openjdk openjdk bot closed this Dec 11, 2023
@openjdk openjdk bot removed ready Ready to be integrated rfr Ready for review labels Dec 11, 2023
@openjdk
Copy link

openjdk bot commented Dec 11, 2023

@kevinrushforth Pushed as commit b389f6d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@kevinrushforth kevinrushforth deleted the 8321636-skip-lighting-macos14-aarch64 branch December 11, 2023 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated
2 participants