-
Notifications
You must be signed in to change notification settings - Fork 492
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8321970: New table columns don't appear when using fixed cell size unless refreshing tableView #1308
8321970: New table columns don't appear when using fixed cell size unless refreshing tableView #1308
Conversation
👋 Welcome back jpereda! A progress list of the required criteria for merging this PR into |
Webrevs
|
stageLoader = new StageLoader(tableView); | ||
stageLoader = new StageLoader(new Scene(tableView)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this changes the context of unrelated tests - no idea whether or not it matters, but I would try not to :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch, actually this changes is a leftover after some changes I did while getting the test to fail... but now I see it is not needed after all.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
verified the fix with the SCEE in the ticket as well as with additional manual tests in the MonkeyTester.
looks good on macOS 14.1.2
@jperedadnr This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
/integrate |
Going to push as commit ab68b71. |
@jperedadnr Pushed as commit ab68b71. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
This PR fixes an issue when a new
TableColumn
is added to aTableView
control with fixed cell size set, where theTableRowSkinBase
failed to add the cells for the new column.A test is included that fails before applying this PR and passes with it.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx.git pull/1308/head:pull/1308
$ git checkout pull/1308
Update a local copy of the PR:
$ git checkout pull/1308
$ git pull https://git.openjdk.org/jfx.git pull/1308/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 1308
View PR using the GUI difftool:
$ git pr show -t 1308
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jfx/pull/1308.diff
Webrev
Link to Webrev Comment