Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8321970: New table columns don't appear when using fixed cell size unless refreshing tableView #1308

Closed

Conversation

jperedadnr
Copy link
Collaborator

@jperedadnr jperedadnr commented Dec 18, 2023

This PR fixes an issue when a new TableColumn is added to a TableView control with fixed cell size set, where the TableRowSkinBase failed to add the cells for the new column.

A test is included that fails before applying this PR and passes with it.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8321970: New table columns don't appear when using fixed cell size unless refreshing tableView (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx.git pull/1308/head:pull/1308
$ git checkout pull/1308

Update a local copy of the PR:
$ git checkout pull/1308
$ git pull https://git.openjdk.org/jfx.git pull/1308/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1308

View PR using the GUI difftool:
$ git pr show -t 1308

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jfx/pull/1308.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 18, 2023

👋 Welcome back jpereda! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Ready for review label Dec 18, 2023
@mlbridge
Copy link

mlbridge bot commented Dec 18, 2023

Webrevs

Comment on lines 85 to 87
stageLoader = new StageLoader(tableView);
stageLoader = new StageLoader(new Scene(tableView));
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this changes the context of unrelated tests - no idea whether or not it matters, but I would try not to :)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, actually this changes is a leftover after some changes I did while getting the test to fail... but now I see it is not needed after all.

Copy link
Contributor

@andy-goryachev-oracle andy-goryachev-oracle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

verified the fix with the SCEE in the ticket as well as with additional manual tests in the MonkeyTester.
looks good on macOS 14.1.2

@openjdk
Copy link

openjdk bot commented Dec 19, 2023

@jperedadnr This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8321970: New table columns don't appear when using fixed cell size unless refreshing tableView

Reviewed-by: angorya

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Ready to be integrated label Dec 19, 2023
@jperedadnr
Copy link
Collaborator Author

/integrate

@openjdk
Copy link

openjdk bot commented Dec 21, 2023

Going to push as commit ab68b71.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 21, 2023
@openjdk openjdk bot closed this Dec 21, 2023
@openjdk openjdk bot removed ready Ready to be integrated rfr Ready for review labels Dec 21, 2023
@openjdk
Copy link

openjdk bot commented Dec 21, 2023

@jperedadnr Pushed as commit ab68b71.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants