-
Notifications
You must be signed in to change notification settings - Fork 471
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8321638: Update to SWT 4.30 #1315
Conversation
👋 Welcome back kcr! A progress list of the required criteria for merging this PR into |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Verified on Windows.
@kevinrushforth This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 2 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
/integrate |
Going to push as commit 2476a3e.
Your commit was automatically rebased without conflicts. |
@kevinrushforth Pushed as commit 2476a3e. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
This PR updates the version of SWT that we use we use when building and testing the
javafx.swt
modules to 4.30.NOTE: we do not distribute SWT, but only use it during build and (manual) test.
We currently use SWT 4.6. In addition to being old, this version does not provide macOS / aarch64 binaries, which are needed for testing on that platform.
I've tested this on all platforms.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx.git pull/1315/head:pull/1315
$ git checkout pull/1315
Update a local copy of the PR:
$ git checkout pull/1315
$ git pull https://git.openjdk.org/jfx.git pull/1315/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 1315
View PR using the GUI difftool:
$ git pr show -t 1315
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jfx/pull/1315.diff
Webrev
Link to Webrev Comment