Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8321638: Update to SWT 4.30 #1315

Closed

Conversation

kevinrushforth
Copy link
Member

@kevinrushforth kevinrushforth commented Jan 3, 2024

This PR updates the version of SWT that we use we use when building and testing the javafx.swt modules to 4.30.

NOTE: we do not distribute SWT, but only use it during build and (manual) test.

We currently use SWT 4.6. In addition to being old, this version does not provide macOS / aarch64 binaries, which are needed for testing on that platform.

I've tested this on all platforms.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx.git pull/1315/head:pull/1315
$ git checkout pull/1315

Update a local copy of the PR:
$ git checkout pull/1315
$ git pull https://git.openjdk.org/jfx.git pull/1315/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1315

View PR using the GUI difftool:
$ git pr show -t 1315

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jfx/pull/1315.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 3, 2024

👋 Welcome back kcr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Ready for review label Jan 3, 2024
@mlbridge
Copy link

mlbridge bot commented Jan 3, 2024

Webrevs

Copy link
Member

@arapte arapte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified on Windows.

@openjdk
Copy link

openjdk bot commented Jan 4, 2024

@kevinrushforth This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8321638: Update to SWT 4.30

Reviewed-by: arapte

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • 2493a23: 8301219: JavaFX crash when closing with the escape key
  • ab68b71: 8321970: New table columns don't appear when using fixed cell size unless refreshing tableView

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Ready to be integrated label Jan 4, 2024
@kevinrushforth
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Jan 4, 2024

Going to push as commit 2476a3e.
Since your change was applied there have been 2 commits pushed to the master branch:

  • 2493a23: 8301219: JavaFX crash when closing with the escape key
  • ab68b71: 8321970: New table columns don't appear when using fixed cell size unless refreshing tableView

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 4, 2024
@openjdk openjdk bot closed this Jan 4, 2024
@openjdk openjdk bot removed ready Ready to be integrated rfr Ready for review labels Jan 4, 2024
@openjdk
Copy link

openjdk bot commented Jan 4, 2024

@kevinrushforth Pushed as commit 2476a3e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@kevinrushforth kevinrushforth deleted the 8321638-swt-4.30 branch January 4, 2024 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants