8237926: Potential memory leak of model data in javafx.scene.control.ListView

[arapte]

The selection model of ListView stores a strong reference to the most recently changed item in SelectedItemsReadOnlyObservableList.itemsListChange, which causes a leak.

Fix:
The below member variables and method of class SelectedItemsReadOnlyObservableList are not required anymore.
Variables: itemsList, itemsListChanged, itemsListChange, itemsListListener.
Method: setItemsList

These members were added when this class was created for JDK-8154216.
But after the fix for JDK-8152396, these class members are not required.

Verification:
No failure in existing tests and added a new test.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8237926: Potential memory leak of model data in javafx.scene.control.ListView

Reviewers

• Kevin Rushforth (kcr - Reviewer)
• Ajit Ghaisas (aghaisas - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/jfx pull/132/head:pull/132
$ git checkout pull/132

[bridgekeeper]

👋 Welcome back arapte! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request.

[mlbridge]

Webrevs

• 01: Full - Incremental (42b454e)
• 00: Full (c859a92)

[kevinrushforth]

/reviewers 2

[openjdk]

@kevinrushforth
The number of required reviews for this PR is now set to 2 (with at least 1 of role reviewers).

[kevinrushforth]

As I mentioned in the bug report for JDK-8240287, I recommend using JDK-8227619 as the bug ID for this fix (and closing JDK-8240287 in JBS as a duplicate). I think that you should be able to just change the title of this PR.

[kevinrushforth]

Is it possible to create a test for the leak?

[arapte]

Hi Kevin, I have updated the PR according to both the comments. Please take a look.

[kevinrushforth]

Thanks. I'll put it on my review queue.

[openjdk]

@arapte This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type /integrate in a new comment to proceed. After integration, the commit message will be:

8237926: Potential memory leak of model data in javafx.scene.control.ListView

Reviewed-by: kcr, aghaisas

• If you would like to add a summary, use the /summary command.
• To credit additional contributors, use the /contributor command.
• To add additional solved issues, use the /solves command.

Since the source branch of this PR was last updated there have been 3 commits pushed to the master branch. Since there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge master into your branch, and then specify the current head hash when integrating, like this: /integrate 960f03908980ad8d76ea2b3c1f1043f2675ec003.

➡️ To integrate this PR with the above commit message, type /integrate in a new comment.

[arapte]

/integrate

[openjdk]

@arapte The following commits have been pushed to master since your change was applied:

• 960f039: 8208761: Update constant collections to use the new immutable collections
• 10c9528: 8240265: iOS: Unnecessary logging on pinch gestures
• 4c132cd: 8237889: Update libxml2 to version 2.9.10

Your commit was automatically rebased without conflicts.

Pushed as commit 337ed72.

[mlbridge]

Mailing list message from Ambarish Rapte on openjfx-dev:

Changeset: 337ed72
Author: Ambarish Rapte <arapte at openjdk.org>
Date: 2020-03-05 03:38:39 +0000
URL: https://git.openjdk.java.net/jfx/commit/337ed722

8237926: Potential memory leak of model data in javafx.scene.control.ListView

Reviewed-by: kcr, aghaisas

! modules/javafx.controls/src/main/java/com/sun/javafx/scene/control/SelectedItemsReadOnlyObservableList.java
! modules/javafx.controls/src/main/java/javafx/scene/control/ListView.java
! modules/javafx.controls/src/main/java/javafx/scene/control/TableView.java
! modules/javafx.controls/src/test/java/test/javafx/scene/control/ListViewTest.java