8324239: JFXPanelHiDPITest fails on Windows 11

[prsadhuk]

Test fails with

JFXPanelHiDPITest > testScale FAILED
    java.lang.NullPointerException: Cannot invoke "java.awt.image.BufferedImage.getWidth()" because "pixelsIm" is null 

because scenePeer is not yet created as the test is run with invokeLater.
FIx is to make it run with invokeAndWait so that it waits for the scene to be created..

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8324239: JFXPanelHiDPITest fails on Windows 11 (Bug - P4)

Reviewers

• Andy Goryachev (@andy-goryachev-oracle - Reviewer)
• Kevin Rushforth (@kevinrushforth - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx.git pull/1344/head:pull/1344
$ git checkout pull/1344

Update a local copy of the PR:
$ git checkout pull/1344
$ git pull https://git.openjdk.org/jfx.git pull/1344/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1344

View PR using the GUI difftool:
$ git pr show -t 1344

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jfx/pull/1344.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back psadhukhan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[mlbridge]

Webrevs

• 03: Full - Incremental (b4ff81a2)
• 02: Full - Incremental (b35b29b9)
• 01: Full - Incremental (09be9a2a)
• 00: Full (36aa3356)

[prsadhuk]

Guess better will be to use Platform.runAndWait for scene to be created

[andy-goryachev-oracle]

is there a reason this test is skipped on macOS?

[kevinrushforth]

is there a reason this test is skipped on macOS?

It's unrelated to this PR, but to answer your question, the test is Windows-specific by it's use of setting glass.win.uiScale.

[andy-goryachev-oracle]

I wish the test class had a description.
It is not immediately apparent that this is a windows-only test without reading the whole thing very carefully.

[andy-goryachev-oracle]

looks good.
Are there any other places where we invokeLater() instead of invokeAndWait()?
And runLater() instead of runAndWait() ?

[openjdk]

@prsadhuk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8324239: JFXPanelHiDPITest fails on Windows 11

Reviewed-by: angorya, kcr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 22 new commits pushed to the master branch:

• 359ffb9: 8308955: MediaPlayer/AudioClip skip data on seek/loop
• 9e7e8e1: 8324270: Update boot JDK to 21.0.2
• 1170658: 8322784: JFXPanel calls InputMethodRequests on wrong thread
• ff4f8e3: 8324237: Typo in comment in GlassApplication.m
• c1c52e5: 8322215: [win] OS events that close the stage can cause Glass to reference freed memory
• 3cf9390: 8323879: constructor Path(Path) which takes another Path object fail to draw on canvas html
• 872dbc8: 8323543: NPE when table items are set to null
• e2bc52d: Merge
• ce3eace: Merge
• 1744050: Merge
• ... and 12 more: https://git.openjdk.org/jfx/compare/5b1fce559d6a3abb8ab19daf6b1177dc4ba3fcdd...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[kevinrushforth]

Are there any other places where we invokeLater() instead of invokeAndWait()?
And runLater() instead of runAndWait() ?

Good question. There might be, but each would need to be looked into to see whether they are causing problems. Also, when doing anything with Swing interop you need to be careful to not introduce a deadlock. It's fine in this specific case.

[kevinrushforth]

The test runs correctly now. Tests should generally use Util.runAndWait instead of PlatformImpl.runAndWait.

[kevinrushforth]

Generally we prefer test.util.Util::runAndWait so that exceptions are propagated.

[andy-goryachev-oracle]

good point!

[prsadhuk]

/integrate

[openjdk]

Going to push as commit 876d535.
Since your change was applied there have been 23 commits pushed to the master branch:

• 767b027: 8324797: Code example in JavaDoc of ObservableValue#when doesn't compile
• 359ffb9: 8308955: MediaPlayer/AudioClip skip data on seek/loop
• 9e7e8e1: 8324270: Update boot JDK to 21.0.2
• 1170658: 8322784: JFXPanel calls InputMethodRequests on wrong thread
• ff4f8e3: 8324237: Typo in comment in GlassApplication.m
• c1c52e5: 8322215: [win] OS events that close the stage can cause Glass to reference freed memory
• 3cf9390: 8323879: constructor Path(Path) which takes another Path object fail to draw on canvas html
• 872dbc8: 8323543: NPE when table items are set to null
• e2bc52d: Merge
• ce3eace: Merge
• ... and 13 more: https://git.openjdk.org/jfx/compare/5b1fce559d6a3abb8ab19daf6b1177dc4ba3fcdd...master

Your commit was automatically rebased without conflicts.

[openjdk]

@prsadhuk Pushed as commit 876d535.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.