Skip to content

8322215: [win] OS events that close the stage can cause Glass to reference freed memory #1347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

beldenfox
Copy link
Contributor

@beldenfox beldenfox commented Jan 23, 2024

This pull request contains a backport of commit c1c52e5a from the openjdk/jfx repository.

The commit being backported was authored by Martin Fox on 22 Jan 2024 and was reviewed by Michael Strauß and Kevin Rushforth.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8322215: [win] OS events that close the stage can cause Glass to reference freed memory (Bug - P3)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx.git pull/1347/head:pull/1347
$ git checkout pull/1347

Update a local copy of the PR:
$ git checkout pull/1347
$ git pull https://git.openjdk.org/jfx.git pull/1347/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1347

View PR using the GUI difftool:
$ git pr show -t 1347

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jfx/pull/1347.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 23, 2024

👋 Welcome back mfox! A progress list of the required criteria for merging this PR into jfx22 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport c1c52e5a42f9a4319487aa9db8e8fcbcf1ba02c8 8322215: [win] OS events that close the stage can cause Glass to reference freed memory Jan 23, 2024
@openjdk
Copy link

openjdk bot commented Jan 23, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport clean rfr Ready for review labels Jan 23, 2024
@mlbridge
Copy link

mlbridge bot commented Jan 23, 2024

Webrevs

@openjdk
Copy link

openjdk bot commented Jan 23, 2024

@beldenfox This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8322215: [win] OS events that close the stage can cause Glass to reference freed memory

Reviewed-by: kcr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the jfx22 branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the jfx22 branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Ready to be integrated label Jan 23, 2024
@beldenfox
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Jan 23, 2024

Going to push as commit b4b576f.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 23, 2024
@openjdk openjdk bot closed this Jan 23, 2024
@openjdk openjdk bot removed ready Ready to be integrated rfr Ready for review labels Jan 23, 2024
@openjdk
Copy link

openjdk bot commented Jan 23, 2024

@beldenfox Pushed as commit b4b576f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants