Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8323880: Caret rendered at wrong position in case of a click event on RTL text #1364

Closed
wants to merge 1 commit into from

Conversation

jaybhaskar
Copy link
Member

@jaybhaskar jaybhaskar commented Feb 13, 2024

Issue: The current implementation of complex text rendering paths on the Java platform is experiencing side effects.
Solution: We need to align with WebKit 616.1 standards. The patch supports two paths simple rendering path and complex rendering path based on text rendering mode.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed (2 reviews required, with at least 1 Reviewer, 1 Author)

Issue

  • JDK-8323880: Caret rendered at wrong position in case of a click event on RTL text (Bug - P3)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx.git pull/1364/head:pull/1364
$ git checkout pull/1364

Update a local copy of the PR:
$ git checkout pull/1364
$ git pull https://git.openjdk.org/jfx.git pull/1364/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1364

View PR using the GUI difftool:
$ git pr show -t 1364

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jfx/pull/1364.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 13, 2024

👋 Welcome back jbhaskar! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title 8323880: Caret rendered at wrong position in case of a click event on… 8323880: Caret rendered at wrong position in case of a click event on RTL text Feb 13, 2024
@openjdk openjdk bot added the rfr Ready for review label Feb 13, 2024
@mlbridge
Copy link

mlbridge bot commented Feb 13, 2024

Webrevs

@kevinrushforth
Copy link
Member

Reviewers: @kevinrushforth @HimaBinduMeda

/reviewers 2

@openjdk
Copy link

openjdk bot commented Feb 13, 2024

@kevinrushforth
The total number of required reviews for this PR (including the jcheck configuration and the last /reviewers command) is now set to 2 (with at least 1 Reviewer, 1 Author).

Copy link
Member

@kevinrushforth kevinrushforth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Tested on macOS.

Copy link
Contributor

@HimaBinduMeda HimaBinduMeda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sanity testing is fine

@openjdk
Copy link

openjdk bot commented Feb 16, 2024

@jaybhaskar This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8323880: Caret rendered at wrong position in case of a click event on RTL text

Reviewed-by: kcr, hmeda

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 5 new commits pushed to the master branch:

  • 48be7d3: 8324182: Deprecate for removal SimpleSelector and CompoundSelector classes
  • 49d7d52: 8325798: Spinner throws uncatchable exception on tab out from garbled text
  • f379eae: 8325873: Update JDK_DOCS property to point to JDK 21 docs
  • e2f42c5: 8325154: resizeColumnToFitContent is slower than it needs to be
  • de0255d: 8307117: TextArea: wrapText property ignored when changing font

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Ready to be integrated label Feb 16, 2024
@jaybhaskar
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Feb 16, 2024

Going to push as commit 1fb56e3.
Since your change was applied there have been 6 commits pushed to the master branch:

  • 2754939: 8309374: Accessibility Focus Rectangle on ListItem is not drawn when ListView is shown for first time
  • 48be7d3: 8324182: Deprecate for removal SimpleSelector and CompoundSelector classes
  • 49d7d52: 8325798: Spinner throws uncatchable exception on tab out from garbled text
  • f379eae: 8325873: Update JDK_DOCS property to point to JDK 21 docs
  • e2f42c5: 8325154: resizeColumnToFitContent is slower than it needs to be
  • de0255d: 8307117: TextArea: wrapText property ignored when changing font

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Feb 16, 2024
@openjdk openjdk bot closed this Feb 16, 2024
@openjdk openjdk bot removed ready Ready to be integrated rfr Ready for review labels Feb 16, 2024
@openjdk
Copy link

openjdk bot commented Feb 16, 2024

@jaybhaskar Pushed as commit 1fb56e3.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@jaybhaskar
Copy link
Member Author

/backport jfx22u

@openjdk
Copy link

openjdk bot commented Feb 16, 2024

@jaybhaskar the backport was successfully created on the branch backport-jaybhaskar-1fb56e33 in my personal fork of openjdk/jfx22u. To create a pull request with this backport targeting openjdk/jfx22u:master, just click the following link:

➡️ Create pull request

The title of the pull request is automatically filled in correctly and below you find a suggestion for the pull request body:

Hi all,

This pull request contains a backport of commit 1fb56e33 from the openjdk/jfx repository.

The commit being backported was authored by Jay Bhaskar on 16 Feb 2024 and was reviewed by Kevin Rushforth and Hima Bindu Meda.

Thanks!

If you need to update the source branch of the pull then run the following commands in a local clone of your personal fork of openjdk/jfx22u:

$ git fetch https://github.com/openjdk-bots/jfx22u.git backport-jaybhaskar-1fb56e33:backport-jaybhaskar-1fb56e33
$ git checkout backport-jaybhaskar-1fb56e33
# make changes
$ git add paths/to/changed/files
$ git commit --message 'Describe additional changes made'
$ git push https://github.com/openjdk-bots/jfx22u.git backport-jaybhaskar-1fb56e33

⚠️ @jaybhaskar You are not yet a collaborator in my fork openjdk-bots/jfx22u. An invite will be sent out and you need to accept it before you can proceed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated
3 participants