Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8324233: Update JPEG Image Decoding Software to 9f #1372

Closed
wants to merge 5 commits into from

Conversation

jayathirthrao
Copy link
Member

@jayathirthrao jayathirthrao commented Feb 20, 2024

IJG has released latest version of libjpeg 9f and we need to update our version also match 9f changes.
IJG reference : https://www.ijg.org/

With updated changes both headless and headful tests are green on all platforms.

Also while updating to 9f noticed that many files don't have latest copyright year and comments from previous version updates like 9e, so updated that part also to match 9f version.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed (2 reviews required, with at least 1 Reviewer, 1 Author)

Issue

  • JDK-8324233: Update JPEG Image Decoding Software to 9f (Bug - P3)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx.git pull/1372/head:pull/1372
$ git checkout pull/1372

Update a local copy of the PR:
$ git checkout pull/1372
$ git pull https://git.openjdk.org/jfx.git pull/1372/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1372

View PR using the GUI difftool:
$ git pr show -t 1372

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jfx/pull/1372.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 20, 2024

👋 Welcome back jdv! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@jayathirthrao jayathirthrao marked this pull request as draft February 20, 2024 06:27
@jayathirthrao jayathirthrao marked this pull request as ready for review February 20, 2024 06:41
@openjdk openjdk bot added the rfr Ready for review label Feb 20, 2024
@mlbridge
Copy link

mlbridge bot commented Feb 20, 2024

Webrevs

@kevinrushforth
Copy link
Member

/reviewers 2

@openjdk
Copy link

openjdk bot commented Feb 21, 2024

@kevinrushforth
The total number of required reviews for this PR (including the jcheck configuration and the last /reviewers command) is now set to 2 (with at least 1 Reviewer, 1 Author).

@jayathirthrao jayathirthrao marked this pull request as draft February 26, 2024 13:02
@openjdk openjdk bot removed the rfr Ready for review label Feb 26, 2024
@jayathirthrao jayathirthrao marked this pull request as ready for review February 28, 2024 05:15
@openjdk openjdk bot added the rfr Ready for review label Feb 28, 2024
Copy link
Member

@kevinrushforth kevinrushforth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. All testing is green.

Copy link
Member

@arapte arapte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a minor query.

@openjdk
Copy link

openjdk bot commented Feb 29, 2024

@jayathirthrao This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8324233: Update JPEG Image Decoding Software to 9f

Reviewed-by: kcr, arapte

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 9 new commits pushed to the master branch:

  • 5512a5a: 8326618: Replace usage of deprecated method getId() in Thread
  • d964573: 8314147: Updated the PhongMaterial documentation
  • df3707d: 8320965: Scrolling on a touch enabled display fails on Wayland
  • b43c4ed: 8325550: Grammatical error in AnchorPane.setLeftAnchor (and other setters) javadoc
  • d9263ab: 8301900: TextArea: Committing text with ENTER in an IME window inserts newline
  • afa206b: 8321603: Bump minimum JDK version for JavaFX to JDK 21
  • e0b88bc: 8278021: Fix warnings in macOS glass native code and treat warnings as errors
  • 9a06bf9: 8322748: Caret blinking in JavaFX should only stop when caret moves
  • ee8633c: 8089373: Translation from character to key code is not sufficient

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@kevinrushforth, @arapte) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Ready to be integrated label Feb 29, 2024
@jayathirthrao
Copy link
Member Author

/integrate

@openjdk openjdk bot added the sponsor Ready to sponsor label Feb 29, 2024
@openjdk
Copy link

openjdk bot commented Feb 29, 2024

@jayathirthrao
Your change (at version b43a51e) is now ready to be sponsored by a Committer.

@arapte
Copy link
Member

arapte commented Feb 29, 2024

/sponsor

@openjdk
Copy link

openjdk bot commented Feb 29, 2024

Going to push as commit b99eb45.
Since your change was applied there have been 9 commits pushed to the master branch:

  • 5512a5a: 8326618: Replace usage of deprecated method getId() in Thread
  • d964573: 8314147: Updated the PhongMaterial documentation
  • df3707d: 8320965: Scrolling on a touch enabled display fails on Wayland
  • b43c4ed: 8325550: Grammatical error in AnchorPane.setLeftAnchor (and other setters) javadoc
  • d9263ab: 8301900: TextArea: Committing text with ENTER in an IME window inserts newline
  • afa206b: 8321603: Bump minimum JDK version for JavaFX to JDK 21
  • e0b88bc: 8278021: Fix warnings in macOS glass native code and treat warnings as errors
  • 9a06bf9: 8322748: Caret blinking in JavaFX should only stop when caret moves
  • ee8633c: 8089373: Translation from character to key code is not sufficient

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Feb 29, 2024
@openjdk openjdk bot closed this Feb 29, 2024
@openjdk openjdk bot removed ready Ready to be integrated rfr Ready for review sponsor Ready to sponsor labels Feb 29, 2024
@openjdk
Copy link

openjdk bot commented Feb 29, 2024

@arapte @jayathirthrao Pushed as commit b99eb45.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@jayathirthrao jayathirthrao deleted the libjpeg branch February 29, 2024 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated
3 participants