Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8240631: Create release notes for JavaFX 14 #139

Closed
wants to merge 1 commit into from

Conversation

@johanvos
Copy link
Collaborator

@johanvos johanvos commented Mar 6, 2020

Add release notes for JavaFX 14 release
Fix for JDK-8240631


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

Reviewers

  • Kevin Rushforth (kcr - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/jfx pull/139/head:pull/139
$ git checkout pull/139

Fix for JDK-8240631
@johanvos johanvos requested a review from kevinrushforth Mar 6, 2020
@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Mar 6, 2020

👋 Welcome back jvos! A progress list of the required criteria for merging this PR into jfx14 will be added to the body of your pull request.

@openjdk openjdk bot added the rfr label Mar 6, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented Mar 6, 2020

Webrevs

@openjdk
Copy link

@openjdk openjdk bot commented Mar 6, 2020

@johanvos This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type /integrate in a new comment to proceed. After integration, the commit message will be:

8240631: Create release notes for JavaFX 14

Reviewed-by: kcr
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /solves command.

➡️ To integrate this PR with the above commit message, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Mar 6, 2020
@johanvos
Copy link
Collaborator Author

@johanvos johanvos commented Mar 7, 2020

/integrate

@openjdk openjdk bot closed this Mar 7, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Mar 7, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Mar 7, 2020

@johanvos
Pushed as commit f8c235b.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Mar 7, 2020

Mailing list message from Johan Vos on openjfx-dev:

Changeset: f8c235b
Author: Johan Vos <jvos at openjdk.org>
Date: 2020-03-07 09:12:44 +0000
URL: https://git.openjdk.java.net/jfx/commit/f8c235bb

8240631: Create release notes for JavaFX 14

Reviewed-by: kcr

+ doc-files/release-notes-14.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.