Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8324326: Update ICU4C to 74.2 #1398

Closed
wants to merge 9 commits into from

Conversation

HimaBinduMeda
Copy link
Contributor

@HimaBinduMeda HimaBinduMeda commented Mar 12, 2024

Updated icu to v74.2. Sanity testing looks fine. Verified build on all platforms


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed (2 reviews required, with at least 1 Reviewer, 1 Author)

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx.git pull/1398/head:pull/1398
$ git checkout pull/1398

Update a local copy of the PR:
$ git checkout pull/1398
$ git pull https://git.openjdk.org/jfx.git pull/1398/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1398

View PR using the GUI difftool:
$ git pr show -t 1398

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jfx/pull/1398.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 12, 2024

👋 Welcome back hmeda! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@kevinrushforth
Copy link
Member

/reviewers 2

@openjdk
Copy link

openjdk bot commented Mar 12, 2024

@kevinrushforth
The total number of required reviews for this PR (including the jcheck configuration and the last /reviewers command) is now set to 2 (with at least 1 Reviewer, 1 Author).

@kevinrushforth
Copy link
Member

@johanvos or @tiainen can one of you be the second reviewer?

Copy link
Member

@kevinrushforth kevinrushforth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't looked at it detail or tested it yet, but I did spot one thing that raises a question.

@openjdk openjdk bot added the rfr Ready for review label Mar 12, 2024
@mlbridge
Copy link

mlbridge bot commented Mar 12, 2024

Webrevs

@openjdk
Copy link

openjdk bot commented Mar 13, 2024

@HimaBinduMeda This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8324326: Update ICU4C to 74.2

Reviewed-by: kcr, sykora

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 5 new commits pushed to the master branch:

  • d0642d0: 8327727: Changing the row factory of a TableView does not recreate the rows
  • 8cb078a: 8328136: Create release notes for JavaFX 22
  • c196454: 8255679: RegionBackgroundImageUITest.unalignedImage_Cover fails because of wrong color
  • 1130584: 8325402: TreeTableRow updateItem() does not check item with isItemChanged(..) unlike all other cell implementations
  • 64af987: 8326989: Text selection issues on WebView after WebKit 617.1

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

Copy link
Collaborator

@tiainen tiainen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds and tests all ran fine.

Copy link
Member

@kevinrushforth kevinrushforth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@openjdk openjdk bot added the ready Ready to be integrated label Mar 16, 2024
@HimaBinduMeda
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Mar 18, 2024

Going to push as commit ad3d44e.
Since your change was applied there have been 6 commits pushed to the master branch:

  • 4e2216b: 8327471: RTLTextFlowCharacterIndexTest fails on Linux
  • d0642d0: 8327727: Changing the row factory of a TableView does not recreate the rows
  • 8cb078a: 8328136: Create release notes for JavaFX 22
  • c196454: 8255679: RegionBackgroundImageUITest.unalignedImage_Cover fails because of wrong color
  • 1130584: 8325402: TreeTableRow updateItem() does not check item with isItemChanged(..) unlike all other cell implementations
  • 64af987: 8326989: Text selection issues on WebView after WebKit 617.1

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 18, 2024
@openjdk openjdk bot closed this Mar 18, 2024
@openjdk openjdk bot removed ready Ready to be integrated rfr Ready for review labels Mar 18, 2024
@openjdk
Copy link

openjdk bot commented Mar 18, 2024

@HimaBinduMeda Pushed as commit ad3d44e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants