8240688: Remove the JavaBeanXxxPropertyBuilders constructors

[nlisker]

Followup to the deprecation of the JavaBeanXxxPropertyBuilders constructors.

CSR

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8240688: Remove the JavaBeanXxxPropertyBuilders constructors

Reviewers

• Kevin Rushforth (kcr - Reviewer)
• Ambarish Rapte (arapte - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/jfx pull/140/head:pull/140
$ git checkout pull/140

[bridgekeeper]

👋 Welcome back nlisker! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request.

[mlbridge]

Webrevs

• 00: Full (7548c72)

[kevinrushforth]

/reviewers 2

[openjdk]

@kevinrushforth
The number of required reviews for this PR is now set to 2 (with at least 1 of role reviewers).

[kevinrushforth]

/csr

[openjdk]

@kevinrushforth has indicated that a compatibility and specification (CSR) request is needed for this pull request.
@nlisker please create a CSR request and add link to it in JDK-8240689. This pull request cannot be integrated until the CSR request is approved.

[nlisker]

Why was the rfr label not reinstated?

[kevinrushforth]

@edvbld @rwestberg This is affected by https://bugs.openjdk.java.net/browse/SKARA-262

[kevinrushforth]

@arapte can you also review this?

[kevinrushforth]

Now the the CSR is approved, we need something to "wake up" the Skara bot to notice that.
@edvbld @rwestberg is there a command that you would recommend to do this? Maybe typing /summary without actually adding a summary? Failing that we can wait for the second reviewer, but it would be nice to test Skara's CSR support prior to that (this is the first one where we've had an approved CSR since starting to use the /csr feature).

[arapte]

Looks good to me.
Observed no build errors for apps, tests.

[openjdk]

@nlisker This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type /integrate in a new comment to proceed. After integration, the commit message will be:

8240688: Remove the JavaBeanXxxPropertyBuilders constructors

Reviewed-by: kcr, arapte

• If you would like to add a summary, use the /summary command.
• To credit additional contributors, use the /contributor command.
• To add additional solved issues, use the /solves command.

Since the source branch of this PR was last updated there has been 1 commit pushed to the master branch. Since there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge master into your branch, and then specify the current head hash when integrating, like this: /integrate cfa119348eb0f1d1a1f73986786cffb083b017eb.

➡️ To integrate this PR with the above commit message, type /integrate in a new comment.

[nlisker]

/integrate

[openjdk]

@nlisker The following commits have been pushed to master since your change was applied:

• cfa1193: 8236685: [macOs] Remove obsolete file dialog subclasses

Your commit was automatically rebased without conflicts.

Pushed as commit e3026b9.

[mlbridge]

Mailing list message from Nir Lisker on openjfx-dev:

Changeset: e3026b9
Author: Nir Lisker <nlisker at openjdk.org>
Date: 2020-03-09 16:38:20 +0000
URL: https://git.openjdk.java.net/jfx/commit/e3026b9c

8240688: Remove the JavaBeanXxxPropertyBuilders constructors

Reviewed-by: kcr, arapte

! modules/javafx.base/src/main/java/javafx/beans/property/adapter/JavaBeanBooleanPropertyBuilder.java
! modules/javafx.base/src/main/java/javafx/beans/property/adapter/JavaBeanDoublePropertyBuilder.java
! modules/javafx.base/src/main/java/javafx/beans/property/adapter/JavaBeanFloatPropertyBuilder.java
! modules/javafx.base/src/main/java/javafx/beans/property/adapter/JavaBeanIntegerPropertyBuilder.java
! modules/javafx.base/src/main/java/javafx/beans/property/adapter/JavaBeanLongPropertyBuilder.java
! modules/javafx.base/src/main/java/javafx/beans/property/adapter/JavaBeanObjectPropertyBuilder.java
! modules/javafx.base/src/main/java/javafx/beans/property/adapter/JavaBeanStringPropertyBuilder.java
! modules/javafx.base/src/main/java/javafx/beans/property/adapter/ReadOnlyJavaBeanBooleanPropertyBuilder.java
! modules/javafx.base/src/main/java/javafx/beans/property/adapter/ReadOnlyJavaBeanDoublePropertyBuilder.java
! modules/javafx.base/src/main/java/javafx/beans/property/adapter/ReadOnlyJavaBeanFloatPropertyBuilder.java
! modules/javafx.base/src/main/java/javafx/beans/property/adapter/ReadOnlyJavaBeanIntegerPropertyBuilder.java
! modules/javafx.base/src/main/java/javafx/beans/property/adapter/ReadOnlyJavaBeanLongPropertyBuilder.java
! modules/javafx.base/src/main/java/javafx/beans/property/adapter/ReadOnlyJavaBeanObjectPropertyBuilder.java
! modules/javafx.base/src/main/java/javafx/beans/property/adapter/ReadOnlyJavaBeanStringPropertyBuilder.java

[mlbridge]

Mailing list message from Eric Bresie on openjfx-dev:

Is there any external skara documentation available on all these flags etc?

Eric Bresie
Ebresie at gmail.com

On March 7, 2020 at 8:25:02 AM CST, Kevin Rushforth <kcr at openjdk.java.net> wrote:
On Fri, 6 Mar 2020 20:46:39 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:

Marked as reviewed by kcr (Lead).

@arapte can you also review this?

Now the the CSR is approved, we need something to "wake up" the Skara bot to notice that.
@edvbld @rwestberg is there a command that you would recommend to do this? Maybe typing `/summary` without actually adding a summary? Failing that we can wait for the second reviewer, but it would be nice to test Skara's CSR support prior to that (this is the first one where we've had an approved CSR since starting to use the `/csr` feature).

-------------

PR: https://git.openjdk.java.net/jfx/pull/140