Skip to content

8328399: Add hs_err_pid* to .gitignore#1408

Closed
andy-goryachev-oracle wants to merge 1 commit intoopenjdk:masterfrom
andy-goryachev-oracle:8328399.ignore
Closed

8328399: Add hs_err_pid* to .gitignore#1408
andy-goryachev-oracle wants to merge 1 commit intoopenjdk:masterfrom
andy-goryachev-oracle:8328399.ignore

Conversation

@andy-goryachev-oracle
Copy link
Contributor

@andy-goryachev-oracle andy-goryachev-oracle commented Mar 18, 2024

Add hs_err_pid* to .gitignore

Q: Any other files?


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8328399: Add hs_err_pid* to .gitignore (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx.git pull/1408/head:pull/1408
$ git checkout pull/1408

Update a local copy of the PR:
$ git checkout pull/1408
$ git pull https://git.openjdk.org/jfx.git pull/1408/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1408

View PR using the GUI difftool:
$ git pr show -t 1408

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jfx/pull/1408.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 18, 2024

👋 Welcome back angorya! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Mar 18, 2024

@andy-goryachev-oracle This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8328399: Add hs_err_pid* to .gitignore

Reviewed-by: aghaisas

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@andy-goryachev-oracle andy-goryachev-oracle marked this pull request as ready for review March 19, 2024 15:41
@openjdk openjdk bot added the rfr Ready for review label Mar 19, 2024
@mlbridge
Copy link

mlbridge bot commented Mar 19, 2024

Webrevs

@aghaisas
Copy link
Collaborator

Q: Any other files?

May be .DS_Store file

@aghaisas
Copy link
Collaborator

Oops... I saw the JBS Description now. It is already ignored.

@openjdk openjdk bot added the ready Ready to be integrated label Mar 19, 2024
@andy-goryachev-oracle
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Mar 20, 2024

Going to push as commit dcb894c.
Since your change was applied there have been 3 commits pushed to the master branch:

  • a71b70f: 8325566: [TestBug] Util.shutdown() to hide ALL Windows
  • 32b452b: 8327482: Fix missing image resource in HelloImage toy app
  • c3396bf: 8207379: Robot screen capture test fails with HiDPI at some screen locations

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 20, 2024
@openjdk openjdk bot closed this Mar 20, 2024
@openjdk openjdk bot removed ready Ready to be integrated rfr Ready for review labels Mar 20, 2024
@openjdk
Copy link

openjdk bot commented Mar 20, 2024

@andy-goryachev-oracle Pushed as commit dcb894c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@andy-goryachev-oracle andy-goryachev-oracle deleted the 8328399.ignore branch March 20, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants