8328749: Remove unused imports in javafx.web #1421

andy-goryachev-oracle · 2024-03-21T21:57:46Z

Using Eclipse IDE to remove unused imports javafx.web module, and update the copyright year to 2024. Using wildcard for more than 10 static imports.

--

This is a trivial change, 1 reviewer is probably enough.

Progress

Change must not contain extraneous whitespace
Commit message must refer to an issue
Change must be properly reviewed (2 reviews required, with at least 1 Reviewer, 1 Author)

Issue

JDK-8328749: Remove unused imports in javafx.web (Bug - P4)

Reviewers

Hima Bindu Meda (@HimaBinduMeda - Committer)
Kevin Rushforth (@kevinrushforth - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx.git pull/1421/head:pull/1421
$ git checkout pull/1421

Update a local copy of the PR:
$ git checkout pull/1421
$ git pull https://git.openjdk.org/jfx.git pull/1421/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1421

View PR using the GUI difftool:
$ git pr show -t 1421

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jfx/pull/1421.diff

Webrev

Link to Webrev Comment

bridgekeeper · 2024-03-21T21:58:22Z

👋 Welcome back angorya! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2024-03-21T21:58:52Z

@andy-goryachev-oracle This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8328749: Remove unused imports in javafx.web

Reviewed-by: hmeda, kcr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 13 new commits pushed to the master branch:

eca3235: 8325900: Emit a warning on macOS if AWT has set the NSAppearance
0d2ad0e: 8273349: Check uses of Stream::peek in controls and replace as needed
bf23732: 8316372: Monkey Tester Application Part 3
7a4d297: 8328754: Fix missing @OVERRIDES in test
9ca8e51: 8328811: Fix missing @OVERRIDES in demos
b3f5a78: 8307980: Rotate Transformation never invalidates inverseCache
6adbcff: 8328750: [TestBug] Improve Stub Font Support
0541f37: 8306322: JDK8130122Test fails intermittently
5d886f8: 8267565: Support "@3x" and greater high-density image naming convention
4beeb89: 8325075: Enable -Werror for javadoc to fail on any warnings
... and 3 more: https://git.openjdk.org/jfx/compare/18eba73cff4aa91ab38ccab64303641388994e21...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

andy-goryachev-oracle · 2024-03-22T15:52:02Z

I suppose I'd need to extract swing into a separate PR, right @kevinrushforth ?

kevinrushforth · 2024-03-22T15:54:43Z

I suppose I'd need to extract swing into a separate PR, right @kevinrushforth ?

Yes. I was just getting ready to write this:

It looks like I spoke too soon when I said it was OK to combine the change to javafx.swing into this PR. You will need to separate it out.

kevinrushforth · 2024-03-22T15:55:20Z

The change to WebWorkerTest can remain, though.

kevinrushforth · 2024-03-22T15:56:55Z

As noted in PR #1424 : There are special considerations when touching files under modules/javafx.web/src/main/native/Source/WebCore/bindings/java/dom3/java, so it will need an extra pair of eyes. Also, this will need to be backported to earlier release trains to keep modules/javafx.web/src/main/native/ identical for all releases.

Reviewers: @kevinrushforth @HimaBinduMeda

/reviewers 2

openjdk · 2024-03-22T15:57:17Z

@kevinrushforth
The total number of required reviews for this PR (including the jcheck configuration and the last /reviewers command) is now set to 2 (with at least 1 Reviewer, 1 Author).

mlbridge · 2024-03-22T16:00:51Z

Webrevs

01: Full - Incremental (8fe2b264)
00: Full (b75bbf83)

andy-goryachev-oracle · 2024-03-22T16:08:22Z

removed swing file from this PR.

HimaBinduMeda · 2024-03-26T07:00:41Z

...src/main/native/Source/WebCore/bindings/java/dom3/java/com/sun/webkit/dom/DOMWindowImpl.java

@@ -37,6 +34,7 @@
 import org.w3c.dom.events.EventTarget;
 import org.w3c.dom.views.AbstractView;
 import org.w3c.dom.views.DocumentView;
+import com.sun.webkit.Disposer;


Minor: Generally, imports are added in alphabetic order.

HimaBinduMeda · 2024-03-26T07:01:02Z

....web/src/main/native/Source/WebCore/bindings/java/dom3/java/com/sun/webkit/dom/NodeImpl.java

@@ -38,6 +35,7 @@
 import org.w3c.dom.events.Event;
 import org.w3c.dom.events.EventListener;
 import org.w3c.dom.events.EventTarget;
+import com.sun.webkit.Disposer;


Minor: Generally, imports are added in alphabetic order.

I raised this question in PR #1420 as well, but didn't follow-up on it. We should make a deliberate decision on this rather than "whatever Andy's version of Eclipse happens to think is a good default". Let's resolve the discussion in that PR and then apply it to all.

HimaBinduMeda

Verified Build and unit tests. No issue seen.
Added few minor comments

kevinrushforth

Looks good.

andy-goryachev-oracle · 2024-04-01T15:00:12Z

/integrate

openjdk · 2024-04-01T15:00:50Z

Going to push as commit a85af13.
Since your change was applied there have been 13 commits pushed to the master branch:

eca3235: 8325900: Emit a warning on macOS if AWT has set the NSAppearance
0d2ad0e: 8273349: Check uses of Stream::peek in controls and replace as needed
bf23732: 8316372: Monkey Tester Application Part 3
7a4d297: 8328754: Fix missing @OVERRIDES in test
9ca8e51: 8328811: Fix missing @OVERRIDES in demos
b3f5a78: 8307980: Rotate Transformation never invalidates inverseCache
6adbcff: 8328750: [TestBug] Improve Stub Font Support
0541f37: 8306322: JDK8130122Test fails intermittently
5d886f8: 8267565: Support "@3x" and greater high-density image naming convention
4beeb89: 8325075: Enable -Werror for javadoc to fail on any warnings
... and 3 more: https://git.openjdk.org/jfx/compare/18eba73cff4aa91ab38ccab64303641388994e21...master

Your commit was automatically rebased without conflicts.

openjdk · 2024-04-01T15:00:56Z

@andy-goryachev-oracle Pushed as commit a85af13.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

8328749: Remove unused imports in javafx.swing, javafx.web

b75bbf8

andy-goryachev-oracle marked this pull request as ready for review March 22, 2024 15:51

openjdk bot added the rfr Ready for review label Mar 22, 2024

kevinrushforth self-requested a review March 22, 2024 15:57

removed swing file

8fe2b26

andy-goryachev-oracle changed the title ~~8328749: Remove unused imports in javafx.swing, javafx.web~~ 8328749: Remove unused imports in javafx.web Mar 22, 2024

HimaBinduMeda reviewed Mar 26, 2024

View reviewed changes

HimaBinduMeda approved these changes Mar 26, 2024

View reviewed changes

kevinrushforth approved these changes Apr 1, 2024

View reviewed changes

openjdk bot added the ready Ready to be integrated label Apr 1, 2024

openjdk bot added the integrated Pull request has been integrated label Apr 1, 2024

openjdk bot closed this Apr 1, 2024

openjdk bot removed ready Ready to be integrated rfr Ready for review labels Apr 1, 2024

andy-goryachev-oracle deleted the 8328749.unused.imports.web branch April 1, 2024 15:16

andy-goryachev-oracle restored the 8328749.unused.imports.web branch April 1, 2024 20:42

andy-goryachev-oracle deleted the 8328749.unused.imports.web branch January 24, 2025 23:39

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

8328749: Remove unused imports in javafx.web #1421

8328749: Remove unused imports in javafx.web #1421

andy-goryachev-oracle commented Mar 21, 2024 •

edited by openjdk bot

Loading

bridgekeeper bot commented Mar 21, 2024

openjdk bot commented Mar 21, 2024 •

edited

Loading

andy-goryachev-oracle commented Mar 22, 2024

kevinrushforth commented Mar 22, 2024

kevinrushforth commented Mar 22, 2024

kevinrushforth commented Mar 22, 2024

openjdk bot commented Mar 22, 2024

mlbridge bot commented Mar 22, 2024 •

edited

Loading

andy-goryachev-oracle commented Mar 22, 2024

HimaBinduMeda Mar 26, 2024

HimaBinduMeda Mar 26, 2024

kevinrushforth Mar 26, 2024

HimaBinduMeda left a comment

kevinrushforth left a comment

andy-goryachev-oracle commented Apr 1, 2024

openjdk bot commented Apr 1, 2024

openjdk bot commented Apr 1, 2024

8328749: Remove unused imports in javafx.web #1421

8328749: Remove unused imports in javafx.web #1421

Conversation

andy-goryachev-oracle commented Mar 21, 2024 • edited by openjdk bot Loading

Progress

Issue

Reviewers

Reviewing

Webrev

bridgekeeper bot commented Mar 21, 2024

openjdk bot commented Mar 21, 2024 • edited Loading

andy-goryachev-oracle commented Mar 22, 2024

kevinrushforth commented Mar 22, 2024

kevinrushforth commented Mar 22, 2024

kevinrushforth commented Mar 22, 2024

openjdk bot commented Mar 22, 2024

mlbridge bot commented Mar 22, 2024 • edited Loading

Webrevs

andy-goryachev-oracle commented Mar 22, 2024

HimaBinduMeda Mar 26, 2024

Choose a reason for hiding this comment

HimaBinduMeda Mar 26, 2024

Choose a reason for hiding this comment

kevinrushforth Mar 26, 2024

Choose a reason for hiding this comment

HimaBinduMeda left a comment

Choose a reason for hiding this comment

kevinrushforth left a comment

Choose a reason for hiding this comment

andy-goryachev-oracle commented Apr 1, 2024

openjdk bot commented Apr 1, 2024

openjdk bot commented Apr 1, 2024

andy-goryachev-oracle commented Mar 21, 2024 •

edited by openjdk bot

Loading

openjdk bot commented Mar 21, 2024 •

edited

Loading

mlbridge bot commented Mar 22, 2024 •

edited

Loading