Skip to content

8328751: Fix missing @Overrides in modules except javafx.web#1423

Closed
andy-goryachev-oracle wants to merge 1 commit intoopenjdk:masterfrom
andy-goryachev-oracle:8328751.override.modules
Closed

8328751: Fix missing @Overrides in modules except javafx.web#1423
andy-goryachev-oracle wants to merge 1 commit intoopenjdk:masterfrom
andy-goryachev-oracle:8328751.override.modules

Conversation

@andy-goryachev-oracle
Copy link
Contributor

@andy-goryachev-oracle andy-goryachev-oracle commented Mar 21, 2024

Fix missing @Overrides in

  • javafx.base
  • javafx.controls
  • javafx.graphics

This is still a trivial change since all the spots are identified by the IDE.

1 reviewer is probably enough.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8328751: Fix missing @Overrides in modules except javafx.web (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx.git pull/1423/head:pull/1423
$ git checkout pull/1423

Update a local copy of the PR:
$ git checkout pull/1423
$ git pull https://git.openjdk.org/jfx.git pull/1423/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1423

View PR using the GUI difftool:
$ git pr show -t 1423

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jfx/pull/1423.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 21, 2024

👋 Welcome back angorya! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Mar 21, 2024

@andy-goryachev-oracle This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8328751: Fix missing @Overrides in modules except javafx.web

Reviewed-by: kcr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 47c6193: 8328667: [Testbug] Enable ignored Spinner unit tests

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@andy-goryachev-oracle andy-goryachev-oracle marked this pull request as ready for review March 21, 2024 23:29
@openjdk openjdk bot added the rfr Ready for review label Mar 21, 2024
@mlbridge
Copy link

mlbridge bot commented Mar 21, 2024

Webrevs

@openjdk openjdk bot added the ready Ready to be integrated label Mar 25, 2024
@andy-goryachev-oracle
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Mar 25, 2024

Going to push as commit 93e3bb2.
Since your change was applied there have been 2 commits pushed to the master branch:

  • 611555e: 8328818: Fix Decora JSL to remove missing @OverRide warnings
  • 47c6193: 8328667: [Testbug] Enable ignored Spinner unit tests

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 25, 2024
@openjdk openjdk bot closed this Mar 25, 2024
@openjdk openjdk bot removed ready Ready to be integrated rfr Ready for review labels Mar 25, 2024
@openjdk
Copy link

openjdk bot commented Mar 25, 2024

@andy-goryachev-oracle Pushed as commit 93e3bb2.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@andy-goryachev-oracle andy-goryachev-oracle deleted the 8328751.override.modules branch March 25, 2024 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants