8328752: Fix missing @Overrides in javafx.web

[andy-goryachev-oracle]

Fix missing @OVERRIDES in javafx.web.

This is still a trivial change since all the spots are identified by the IDE.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed (2 reviews required, with at least 1 Reviewer, 1 Author)

Issue

• JDK-8328752: Fix missing @Overrides in javafx.web (Bug - P4)

Reviewers

• Kevin Rushforth (@kevinrushforth - Reviewer)
• Hima Bindu Meda (@HimaBinduMeda - Committer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx.git pull/1424/head:pull/1424
$ git checkout pull/1424

Update a local copy of the PR:
$ git checkout pull/1424
$ git pull https://git.openjdk.org/jfx.git pull/1424/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1424

View PR using the GUI difftool:
$ git pr show -t 1424

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jfx/pull/1424.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back angorya! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@andy-goryachev-oracle This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8328752: Fix missing @Overrides in javafx.web

Reviewed-by: kcr, hmeda

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 20 new commits pushed to the master branch:

• c41b000: 8328742: Remove unused imports in manual tests
• c08a6b7: 8328745: Remove unused imports in system tests
• 4e0a229: 8328718: Remove unused imports in javafx.controls
• 01a1d90: 8328746: Remove unused imports in demo apps
• edbb88f: 8328820: Remove unused imports in javafx.swing
• 3761d37: 8328739: Remove unused imports in javafx.graphics
• a85af13: 8328749: Remove unused imports in javafx.web
• eca3235: 8325900: Emit a warning on macOS if AWT has set the NSAppearance
• 0d2ad0e: 8273349: Check uses of Stream::peek in controls and replace as needed
• bf23732: 8316372: Monkey Tester Application Part 3
• ... and 10 more: https://git.openjdk.org/jfx/compare/18eba73cff4aa91ab38ccab64303641388994e21...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[mlbridge]

Webrevs

• 00: Full (59557951)

[kevinrushforth]

There are special considerations when touching files under modules/javafx.web/src/main/native/Source/WebCore/bindings/java/dom3/java, so it will need an extra pair of eyes. Also, this will need to be backported to earlier release trains to keep modules/javafx.web/src/main/native/ identical for all releases.

Reviewers: @kevinrushforth @HimaBinduMeda

/reviewers 2

[openjdk]

@kevinrushforth
The total number of required reviews for this PR (including the jcheck configuration and the last /reviewers command) is now set to 2 (with at least 1 Reviewer, 1 Author).

[andy-goryachev-oracle]

@HimaBinduMeda could you please take a look at this? Once reviewed, I'll start the back port chain. Thank you!

[kevinrushforth]

These changes look good.

[HimaBinduMeda]

Changes look good

[andy-goryachev-oracle]

thank you @HimaBinduMeda !

[andy-goryachev-oracle]

/integrate

[openjdk]

Going to push as commit 483c640.
Since your change was applied there have been 20 commits pushed to the master branch:

• c41b000: 8328742: Remove unused imports in manual tests
• c08a6b7: 8328745: Remove unused imports in system tests
• 4e0a229: 8328718: Remove unused imports in javafx.controls
• 01a1d90: 8328746: Remove unused imports in demo apps
• edbb88f: 8328820: Remove unused imports in javafx.swing
• 3761d37: 8328739: Remove unused imports in javafx.graphics
• a85af13: 8328749: Remove unused imports in javafx.web
• eca3235: 8325900: Emit a warning on macOS if AWT has set the NSAppearance
• 0d2ad0e: 8273349: Check uses of Stream::peek in controls and replace as needed
• bf23732: 8316372: Monkey Tester Application Part 3
• ... and 10 more: https://git.openjdk.org/jfx/compare/18eba73cff4aa91ab38ccab64303641388994e21...master

Your commit was automatically rebased without conflicts.

[openjdk]

@andy-goryachev-oracle Pushed as commit 483c640.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.