Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8239107: Update libjpeg to version 9d #143

Closed
wants to merge 1 commit into from

Conversation

arapte
Copy link
Member

@arapte arapte commented Mar 12, 2020

Currently we use IJG libjpeg version 9c released on 14-Jan-2018
We should update the libjpeg to latest version 9d released on 12-Jan-2020

reference: https://jpegclub.org/reference/reference-sources/


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

Reviewers

  • Kevin Rushforth (kcr - Reviewer)
  • Arun Joseph (ajoseph - Author)

Download

$ git fetch https://git.openjdk.java.net/jfx pull/143/head:pull/143
$ git checkout pull/143

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 12, 2020

👋 Welcome back arapte! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request.

@openjdk openjdk bot added the rfr Ready for review label Mar 12, 2020
@mlbridge
Copy link

mlbridge bot commented Mar 12, 2020

Webrevs

@kevinrushforth
Copy link
Member

/reviewers 2

@kevinrushforth kevinrushforth self-requested a review March 12, 2020 11:53
@openjdk
Copy link

openjdk bot commented Mar 12, 2020

@kevinrushforth
The number of required reviews for this PR is now set to 2 (with at least 1 of role reviewers).

@openjdk
Copy link

openjdk bot commented Mar 17, 2020

@arapte This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type /integrate in a new comment to proceed. After integration, the commit message will be:

8239107: Update libjpeg to version 9d

Reviewed-by: kcr, ajoseph
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /solves command.

Since the source branch of this PR was last updated there have been 6 commits pushed to the master branch. Since there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge master into your branch, and then specify the current head hash when integrating, like this: /integrate b81cf32b98cc1e857bccf4691c1576a6e559a05b.

➡️ To integrate this PR with the above commit message, type /integrate in a new comment.

@openjdk openjdk bot added the ready Ready to be integrated label Mar 17, 2020
@arapte
Copy link
Member Author

arapte commented Mar 18, 2020

/integrate

@openjdk openjdk bot closed this Mar 18, 2020
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Ready to be integrated labels Mar 18, 2020
@openjdk
Copy link

openjdk bot commented Mar 18, 2020

@arapte The following commits have been pushed to master since your change was applied:

  • b81cf32: 8236259: MemoryLeak in ProgressIndicator
  • 9ea7f96: 8240832: Remove unused applecoreaudio.md third-party legal file
  • 0fc1420: Merge
  • f8c235b: 8240631: Create release notes for JavaFX 14
  • 50e15fc: 8240466: AppJSCallback* apps launched by ModuleLauncherTest intermittently hang
  • e3026b9: 8240688: Remove the JavaBeanXxxPropertyBuilders constructors

Your commit was automatically rebased without conflicts.

Pushed as commit 90289a2.

@openjdk openjdk bot removed the rfr Ready for review label Mar 18, 2020
@mlbridge
Copy link

mlbridge bot commented Mar 18, 2020

Mailing list message from Ambarish Rapte on openjfx-dev:

Changeset: 90289a2
Author: Ambarish Rapte <arapte at openjdk.org>
Date: 2020-03-18 05:57:46 +0000
URL: https://git.openjdk.java.net/jfx/commit/90289a23

8239107: Update libjpeg to version 9d

Reviewed-by: kcr, ajoseph

! modules/javafx.graphics/src/main/legal/jpeg_fx.md
! modules/javafx.graphics/src/main/native-iio/libjpeg/README
! modules/javafx.graphics/src/main/native-iio/libjpeg/UPDATING.txt
! modules/javafx.graphics/src/main/native-iio/libjpeg/jccolor.c
! modules/javafx.graphics/src/main/native-iio/libjpeg/jchuff.c
! modules/javafx.graphics/src/main/native-iio/libjpeg/jcinit.c
! modules/javafx.graphics/src/main/native-iio/libjpeg/jcmarker.c
! modules/javafx.graphics/src/main/native-iio/libjpeg/jcmaster.c
! modules/javafx.graphics/src/main/native-iio/libjpeg/jcomapi.c
! modules/javafx.graphics/src/main/native-iio/libjpeg/jcparam.c
! modules/javafx.graphics/src/main/native-iio/libjpeg/jdcolor.c
! modules/javafx.graphics/src/main/native-iio/libjpeg/jdct.h
! modules/javafx.graphics/src/main/native-iio/libjpeg/jdhuff.c
! modules/javafx.graphics/src/main/native-iio/libjpeg/jdmarker.c
! modules/javafx.graphics/src/main/native-iio/libjpeg/jdmaster.c
! modules/javafx.graphics/src/main/native-iio/libjpeg/jdmerge.c
! modules/javafx.graphics/src/main/native-iio/libjpeg/jdtrans.c
! modules/javafx.graphics/src/main/native-iio/libjpeg/jerror.h
! modules/javafx.graphics/src/main/native-iio/libjpeg/jfdctint.c
! modules/javafx.graphics/src/main/native-iio/libjpeg/jidctint.c
! modules/javafx.graphics/src/main/native-iio/libjpeg/jmemmgr.c
! modules/javafx.graphics/src/main/native-iio/libjpeg/jmemnobs.c
! modules/javafx.graphics/src/main/native-iio/libjpeg/jpegint.h
! modules/javafx.graphics/src/main/native-iio/libjpeg/jpeglib.h
! modules/javafx.graphics/src/main/native-iio/libjpeg/jutils.c
! modules/javafx.graphics/src/main/native-iio/libjpeg/jversion.h

@arapte arapte deleted the update_libjpeg branch April 28, 2020 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants