-
Notifications
You must be signed in to change notification settings - Fork 464
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8332328: [GHA] GitHub Actions build fails on Linux: unable to find gcc-13 #1457
Conversation
…c-13 Upgrade Linux build platform to Ubuntu 24.04
👋 Welcome back kcr! A progress list of the required criteria for merging this PR into |
@kevinrushforth This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
/summary Upgrade GHA Linux build platform to Ubuntu 24.04 |
@kevinrushforth Setting summary to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good
/integrate |
Going to push as commit d7ab551. |
@kevinrushforth Pushed as commit d7ab551. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Note that the Ubuntu 24 runner is in beta: https://github.com/actions/runner-images#available-images. |
Hopefully we won't see any instability as a result. If we do, then we might need to figure out how to get gcc-13 back on Ubuntu 22.04. We should keep an eye out for any odd Linux failures. |
it's working for me - Thank you for fixing the setup! |
It looks like the list of packages available in the Ubuntu 22.04 GitHub Actions test runner no longer includes
gcc-13
as of yesterday. I didn't find any documentation to indicate that this was intentional, but now that Ubuntu 24.04 is available we can fix the problem by updating to that version. We will need to do this at some point anyway, so we might as well do it now.With this fix, the GHA test build now passes on all platforms. See the test results to verify this.
Given that GHA builds are currently broken on Linux, and that this fix doesn't affect the product at all (just our GHA tests), I will integrate this as soon as it is approved by 1 Reviewer, as an exception to the usual requirement to wait for 24 hours.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx.git pull/1457/head:pull/1457
$ git checkout pull/1457
Update a local copy of the PR:
$ git checkout pull/1457
$ git pull https://git.openjdk.org/jfx.git pull/1457/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 1457
View PR using the GUI difftool:
$ git pr show -t 1457
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jfx/pull/1457.diff
Webrev
Link to Webrev Comment