Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8332539: Update libxml2 to 2.12.7 #1464

Closed
wants to merge 3 commits into from

Conversation

HimaBinduMeda
Copy link
Contributor

@HimaBinduMeda HimaBinduMeda commented May 24, 2024

Updated libxml to v2.12.7. Sanity testing looks fine. No issue seen


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed (2 reviews required, with at least 1 Reviewer, 1 Author)

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx.git pull/1464/head:pull/1464
$ git checkout pull/1464

Update a local copy of the PR:
$ git checkout pull/1464
$ git pull https://git.openjdk.org/jfx.git pull/1464/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1464

View PR using the GUI difftool:
$ git pr show -t 1464

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jfx/pull/1464.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented May 24, 2024

👋 Welcome back hmeda! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented May 24, 2024

@HimaBinduMeda This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8332539: Update libxml2 to 2.12.7

Reviewed-by: kcr, sykora

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 31fe622: 8332732: Clean up non-standard use of /// comments in JavaFX

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@HimaBinduMeda HimaBinduMeda changed the title 8332539:Update libxml2 to 2.12.7 8332539: Update libxml2 to 2.12.7 May 24, 2024
@openjdk openjdk bot added the rfr Ready for review label May 24, 2024
@kevinrushforth
Copy link
Member

Reviewers: @kevinrushforth @tiainen

/reviewers 2

@openjdk
Copy link

openjdk bot commented May 24, 2024

@kevinrushforth
The total number of required reviews for this PR (including the jcheck configuration and the last /reviewers command) is now set to 2 (with at least 1 Reviewer, 1 Author).

@mlbridge
Copy link

mlbridge bot commented May 24, 2024

Webrevs

Copy link
Member

@kevinrushforth kevinrushforth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes look good. Tests are green.

Copy link
Collaborator

@tiainen tiainen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are green here as well.

@openjdk openjdk bot added the ready Ready to be integrated label May 27, 2024
@HimaBinduMeda
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented May 28, 2024

Going to push as commit dedcf1d.
Since your change was applied there has been 1 commit pushed to the master branch:

  • 31fe622: 8332732: Clean up non-standard use of /// comments in JavaFX

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 28, 2024
@openjdk openjdk bot closed this May 28, 2024
@openjdk openjdk bot removed ready Ready to be integrated rfr Ready for review labels May 28, 2024
@openjdk
Copy link

openjdk bot commented May 28, 2024

@HimaBinduMeda Pushed as commit dedcf1d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants