Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8241455: Memory leak on replacing selection/focusModel #148

Closed
wants to merge 3 commits into from
Closed
Changes from 1 commit
Commits
File filter...
Filter file types
Jump to…
Jump to file
Failed to load files.

Always

Just for now

@@ -196,11 +196,10 @@ public void testListViewSelectionModel() {
public void testTabPaneSelectionModel() {
// FIXME
// can't formally ignore just one parameter, so backing out if showBeforeReplaceSM
// has its own issue https://bugs.openjdk.java.net/browse/JDK-8241737
if (showBeforeReplaceSM) return;
if (showBeforeReplaceSM) return; //@Ignore("8241737")
TabPane control = new TabPane();
ObservableList<String> data = FXCollections.observableArrayList("Apple", "Orange", "Banana");
data.forEach(text -> control.getTabs().add(new Tab("text")));
data.forEach(text -> control.getTabs().add(new Tab(text)));
WeakReference<SelectionModel<?>> weakRef = new WeakReference<>(control.getSelectionModel());
SingleSelectionModel<Tab> replacingSm = TabPaneShim.getTabPaneSelectionModel(control);
maybeShowControl(control);
@@ -224,8 +223,8 @@ public void testComboBoxSelectionModel() {
public void testChoiceBoxSelectionModel() {
// FIXME
// can't formally ignore just one parameter, so backing out if showBeforeReplaceSM
// will be fixed as side-effect of skin cleanup in https://bugs.openjdk.java.net/browse/JDK-8087555
if (showBeforeReplaceSM) return;
// will be fixed as side-effect of skin cleanup
if (showBeforeReplaceSM) return; //@Ignore("8087555")
ChoiceBox<String> control = new ChoiceBox<>(FXCollections.observableArrayList("Apple", "Orange", "Banana"));
WeakReference<SelectionModel<?>> weakRef = new WeakReference<>(control.getSelectionModel());
SingleSelectionModel<String> replacingSm = ChoiceBoxShim.get_ChoiceBoxSelectionModel(control);
ProTip! Use n and p to navigate between commits in a pull request.