Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8335633: Missing @Override in Dimension #1494

Conversation

andy-goryachev-oracle
Copy link
Contributor

@andy-goryachev-oracle andy-goryachev-oracle commented Jul 3, 2024

added missing @OverRide annotations


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8335633: Missing @Override in Dimension (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx.git pull/1494/head:pull/1494
$ git checkout pull/1494

Update a local copy of the PR:
$ git checkout pull/1494
$ git pull https://git.openjdk.org/jfx.git pull/1494/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1494

View PR using the GUI difftool:
$ git pr show -t 1494

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jfx/pull/1494.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 3, 2024

👋 Welcome back angorya! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jul 3, 2024

@andy-goryachev-oracle This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8335633: Missing @Override in Dimension

Reviewed-by: jhendrikx, azvegint

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@andy-goryachev-oracle andy-goryachev-oracle marked this pull request as ready for review July 3, 2024 17:51
@openjdk openjdk bot added the rfr Ready for review label Jul 3, 2024
@mlbridge
Copy link

mlbridge bot commented Jul 3, 2024

Webrevs

@openjdk openjdk bot added the ready Ready to be integrated label Jul 3, 2024
@andy-goryachev-oracle
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Jul 5, 2024

Going to push as commit 72701e6.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jul 5, 2024
@openjdk openjdk bot closed this Jul 5, 2024
@openjdk openjdk bot removed ready Ready to be integrated rfr Ready for review labels Jul 5, 2024
@openjdk
Copy link

openjdk bot commented Jul 5, 2024

@andy-goryachev-oracle Pushed as commit 72701e6.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@andy-goryachev-oracle andy-goryachev-oracle deleted the 8335633.missing branch July 5, 2024 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants