Skip to content

8295945: Revert unintended change to copyright start year#1496

Closed
arapte wants to merge 1 commit intoopenjdk:masterfrom
arapte:copyright-year-correction
Closed

8295945: Revert unintended change to copyright start year#1496
arapte wants to merge 1 commit intoopenjdk:masterfrom
arapte:copyright-year-correction

Conversation

@arapte
Copy link
Member

@arapte arapte commented Jul 8, 2024

A quick fix to correct the created copyright year.
The created year in the header was unintentionally modified previously from 2021 to 2017.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8295945: Revert unintended change to copyright start year (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx.git pull/1496/head:pull/1496
$ git checkout pull/1496

Update a local copy of the PR:
$ git checkout pull/1496
$ git pull https://git.openjdk.org/jfx.git pull/1496/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1496

View PR using the GUI difftool:
$ git pr show -t 1496

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jfx/pull/1496.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 8, 2024

👋 Welcome back arapte! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jul 8, 2024

@arapte This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8295945: Revert unintended change to copyright start year

Reviewed-by: kcr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the rfr Ready for review label Jul 8, 2024
@mlbridge
Copy link

mlbridge bot commented Jul 8, 2024

Webrevs

@openjdk openjdk bot added the ready Ready to be integrated label Jul 8, 2024
@arapte
Copy link
Member Author

arapte commented Jul 9, 2024

/integrate

@openjdk
Copy link

openjdk bot commented Jul 9, 2024

Going to push as commit dbda2cc.
Since your change was applied there have been 2 commits pushed to the master branch:

  • 9723a9c: 8322619: Parts of SG no longer update during rendering - overlapping - culling - dirty
  • 56e07db: 8335216: [windows] Missing error check for GetSystemDirectory in glass

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jul 9, 2024
@openjdk openjdk bot closed this Jul 9, 2024
@openjdk openjdk bot removed ready Ready to be integrated rfr Ready for review labels Jul 9, 2024
@openjdk
Copy link

openjdk bot commented Jul 9, 2024

@arapte Pushed as commit dbda2cc.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@arapte arapte deleted the copyright-year-correction branch October 8, 2025 02:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants