Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8328994 : Update WebKit to 619.1 #1502

Closed
wants to merge 2 commits into from

Conversation

HimaBinduMeda
Copy link
Contributor

@HimaBinduMeda HimaBinduMeda commented Jul 12, 2024

This PR updates Webkit to v619.1.
Build is verified in mac , windows and linux. Sanity testing looks fine. No issues seen.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed (2 reviews required, with at least 1 Reviewer, 1 Author)

Issue

Reviewers

Contributors

  • Jay Bhaskar <jbhaskar@openjdk.org>

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx.git pull/1502/head:pull/1502
$ git checkout pull/1502

Update a local copy of the PR:
$ git checkout pull/1502
$ git pull https://git.openjdk.org/jfx.git pull/1502/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1502

View PR using the GUI difftool:
$ git pr show -t 1502

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jfx/pull/1502.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 12, 2024

👋 Welcome back hmeda! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jul 12, 2024

@HimaBinduMeda This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8328994: Update WebKit to 619.1

Co-authored-by: Jay Bhaskar <jbhaskar@openjdk.org>
Reviewed-by: kcr, sykora

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • e3c1595: 8336272: SizeToSceneTest: fullScreen tests fail on Ubuntu 22.04
  • 5b448b8: 8296387: [Tooltip, CSS] -fx-show-delay is only applied to the first tooltip that is shown before it is displayed

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the rfr Ready for review label Jul 12, 2024
@mlbridge
Copy link

mlbridge bot commented Jul 12, 2024

Webrevs

  • 00: [Full](Webrev is not available because diff is too large) (a67a51f6)

@HimaBinduMeda
Copy link
Contributor Author

/contributor add @jaybhaskar

@openjdk
Copy link

openjdk bot commented Jul 12, 2024

@HimaBinduMeda
Contributor Jay Bhaskar <jbhaskar@openjdk.org> successfully added.

@kevinrushforth
Copy link
Member

Reviewers: @kevinrushforth and @tiainen or @johanvos

/reviewers 2

@openjdk
Copy link

openjdk bot commented Jul 12, 2024

@kevinrushforth
The total number of required reviews for this PR (including the jcheck configuration and the last /reviewers command) is now set to 2 (with at least 1 Reviewer, 1 Author).

@kevinrushforth kevinrushforth self-requested a review July 12, 2024 15:35
@kevinrushforth
Copy link
Member

Everything looks good. I'll finish my testing and approve on Monday.

Copy link
Collaborator

@tiainen tiainen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All builds succeeded.

@openjdk openjdk bot added the ready Ready to be integrated label Jul 16, 2024
@HimaBinduMeda
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Jul 16, 2024

Going to push as commit 34bbf85.
Since your change was applied there have been 2 commits pushed to the master branch:

  • e3c1595: 8336272: SizeToSceneTest: fullScreen tests fail on Ubuntu 22.04
  • 5b448b8: 8296387: [Tooltip, CSS] -fx-show-delay is only applied to the first tooltip that is shown before it is displayed

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jul 16, 2024
@openjdk openjdk bot closed this Jul 16, 2024
@openjdk openjdk bot removed ready Ready to be integrated rfr Ready for review labels Jul 16, 2024
@openjdk
Copy link

openjdk bot commented Jul 16, 2024

@HimaBinduMeda Pushed as commit 34bbf85.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants