-
Notifications
You must be signed in to change notification settings - Fork 487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8328994 : Update WebKit to 619.1 #1502
Conversation
👋 Welcome back hmeda! A progress list of the required criteria for merging this PR into |
@HimaBinduMeda This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 2 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
Webrevs
|
/contributor add @jaybhaskar |
@HimaBinduMeda |
Reviewers: @kevinrushforth and @tiainen or @johanvos /reviewers 2 |
@kevinrushforth |
Everything looks good. I'll finish my testing and approve on Monday. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All builds succeeded.
/integrate |
Going to push as commit 34bbf85.
Your commit was automatically rebased without conflicts. |
@HimaBinduMeda Pushed as commit 34bbf85. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
This PR updates Webkit to v619.1.
Build is verified in mac , windows and linux. Sanity testing looks fine. No issues seen.
Progress
Issue
Reviewers
Contributors
<jbhaskar@openjdk.org>
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx.git pull/1502/head:pull/1502
$ git checkout pull/1502
Update a local copy of the PR:
$ git checkout pull/1502
$ git pull https://git.openjdk.org/jfx.git pull/1502/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 1502
View PR using the GUI difftool:
$ git pr show -t 1502
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jfx/pull/1502.diff
Webrev
Link to Webrev Comment