New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8240542: Switch FX build to use JDK 14 as boot JDK #152
Conversation
|
/reviewers 2 |
@kevinrushforth |
@arapte can you also review this? |
@tiainen can you also take a look? |
Looks ok to me. All our jenkins jobs ran successfully using JDK 14. |
Isn't |
gradle's java plugin translates We could look into changing it if gradle provides that support, but that would be a separate issue, independent from upgrading the boot JDK from 13 to 14. |
@kevinrushforth This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type
Since the source branch of this PR was last updated there have been 3 commits pushed to the
|
/integrate |
@kevinrushforth The following commits have been pushed to master since your change was applied:
Your commit was automatically rebased without conflicts. Pushed as commit 159f651. |
Now that we have switched to using gradle 6.3 we can switch to using JDK 14 as the boot JDK for JavaFX 15 builds.
This will not change the minimum JDK version needed to build or run JavaFX, which remains at 11. We will continue to generate class files using
-source 11 -target 11
.Progress
Issue
Reviewers
Download
$ git fetch https://git.openjdk.java.net/jfx pull/152/head:pull/152
$ git checkout pull/152