Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8240542: Switch FX build to use JDK 14 as boot JDK #152

Closed

Conversation

kevinrushforth
Copy link
Member

@kevinrushforth kevinrushforth commented Mar 26, 2020

Now that we have switched to using gradle 6.3 we can switch to using JDK 14 as the boot JDK for JavaFX 15 builds.

This will not change the minimum JDK version needed to build or run JavaFX, which remains at 11. We will continue to generate class files using -source 11 -target 11.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8240542: Switch FX build to use JDK 14 as boot JDK

Reviewers

  • Johan Vos (jvos - Reviewer)
  • Ambarish Rapte (arapte - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/jfx pull/152/head:pull/152
$ git checkout pull/152

@kevinrushforth kevinrushforth requested a review from johanvos Mar 26, 2020
@kevinrushforth kevinrushforth self-assigned this Mar 26, 2020
@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Mar 26, 2020

👋 Welcome back kcr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request.

@kevinrushforth
Copy link
Member Author

@kevinrushforth kevinrushforth commented Mar 26, 2020

/reviewers 2

@openjdk openjdk bot added the rfr label Mar 26, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Mar 26, 2020

@kevinrushforth
The number of required reviews for this PR is now set to 2 (with at least 1 of role reviewers).

@kevinrushforth
Copy link
Member Author

@kevinrushforth kevinrushforth commented Mar 26, 2020

@arapte can you also review this?

@mlbridge
Copy link

@mlbridge mlbridge bot commented Mar 26, 2020

Webrevs

@kevinrushforth
Copy link
Member Author

@kevinrushforth kevinrushforth commented Mar 26, 2020

@tiainen can you also take a look?

@tiainen
Copy link
Collaborator

@tiainen tiainen commented Mar 26, 2020

Looks ok to me. All our jenkins jobs ran successfully using JDK 14.

@nlisker
Copy link
Collaborator

@nlisker nlisker commented Mar 27, 2020

We will continue to generate class files using -source 11 -target 11

Isn't -release 11 the preferred way?

@kevinrushforth
Copy link
Member Author

@kevinrushforth kevinrushforth commented Mar 27, 2020

gradle's java plugin translates sourceCompatibility NN into -source NN -target NN. I haven't looked into whether gradle has a way to use -release. In practice, what it means is that we need to be careful not to use newer API from a newer JDK.

We could look into changing it if gradle provides that support, but that would be a separate issue, independent from upgrading the boot JDK from 13 to 14.

arapte
arapte approved these changes Mar 31, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Mar 31, 2020

@kevinrushforth This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type /integrate in a new comment to proceed. After integration, the commit message will be:

8240542: Switch FX build to use JDK 14 as boot JDK

Reviewed-by: jvos, arapte
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /solves command.

Since the source branch of this PR was last updated there have been 3 commits pushed to the master branch. Since there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge master into your branch, and then specify the current head hash when integrating, like this: /integrate 159f6516879ca1d176223b2e28ee19a0ad1e3e19.

➡️ To integrate this PR with the above commit message, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Mar 31, 2020
@kevinrushforth
Copy link
Member Author

@kevinrushforth kevinrushforth commented Mar 31, 2020

/integrate

@openjdk openjdk bot closed this Mar 31, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Mar 31, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Mar 31, 2020

@kevinrushforth The following commits have been pushed to master since your change was applied:

  • 6d098fe: 8234959: FXMLLoader does not populate ENGINE_SCOPE Bindings with FILENAME and ARGV
  • d7f13f4: 8089828: RTL Orientation, the flag of a mnemonic is not placed under the mnemonic letter.

Your commit was automatically rebased without conflicts.

Pushed as commit 159f651.

@kevinrushforth kevinrushforth deleted the 8240542-bootjdk-14 branch Apr 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated
5 participants