Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8241840: Memoryleak: Closed focused Stages are not collected with Monocle. #153
8241840: Memoryleak: Closed focused Stages are not collected with Monocle. #153
Changes from 1 commit
26660df
7f535de
991d3ff
20865db
5992550
d5cb902
3f618c1
b4c0651
4cfe3ca
a7c9d83
2971a11
File filter...
Jump to…
kevinrushforthAug 7, 2020
Member
Minor: Add missing newline
kevinrushforthAug 13, 2020
Member
I meant that the file should end with a newline (it doesn't matter whether or not there is a newline before the final closing brace). The red circle with a
-
in it is GitHub's way of showing you that the file doesn't end with a newline.FlorianKirmaierAug 14, 2020
Author
Member
done
kevinrushforthAug 7, 2020
Member
Minor: Add missing newline
kevinrushforthAug 13, 2020
Member
Same as in previous file.
FlorianKirmaierAug 14, 2020
Author
Member
done
kevinrushforthAug 7, 2020
Member
The preferred order is
public abstract
. Also, there is no need for an@Ignore
here.kevinrushforthAug 7, 2020
Member
Minor: remove extra blank line.
kevinrushforthAug 7, 2020
Member
These two can be instance fields (which is usually preferred for test variables).
FlorianKirmaierAug 9, 2020
Author
Member
They are called from the following static method:
kevinrushforthAug 13, 2020
Member
No, these two are only used from
testClosedFocusedStageLeakBase
, which is an instance method. I removedstatic
while testing it and it compiles and runs fine.FlorianKirmaierAug 14, 2020
Author
Member
You are right, I've probably picked up the other 2 static variables.
kevinrushforthAug 7, 2020
Member
Minor: Add missing newline
kevinrushforthAug 13, 2020
Member
Same as in previous file.
FlorianKirmaierAug 14, 2020
Author
Member
done